Fix searching for base build when triggering OpenScanHub scan

[nforro]

Fixes #2495.

Two notes:

• I'm not sure what are the performance implications of enabling require_git_repo_in_local_project
• In case there are no successful builds but there are a lot of commits it could take a while before it fails, however I'm not sure how to detect such case

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/e841814aa6c54f81b578864932bca57c

✔️ pre-commit SUCCESS in 2m 14s
✔️ packit-service-tests SUCCESS in 2m 37s

[lbarcziova]

I'm not sure what are the performance implications of enabling require_git_repo_in_local_project

it means now for the copr build handler tasks, the git repo would be cloned, which we tried to avoid previously :/ do you think we could solve this in another way?

[nforro]

it means now for the copr build handler tasks, the git repo would be cloned, which we tried to avoid previously :/ do you think we could solve this in another way?

I suppose it would be possible (though a bit hacky) to only enable require_git_repo_in_local_project per instance and rebuild LocalProject, would that make sense?

[lbarcziova]

I am still not sure we should be cloning the whole repo to get few commit hashes, what about getting it via API?

[nforro]

I am still not sure we should be cloning the whole repo to get few commit hashes, what about getting it via API?

It seems possible for GitHub and GitLab, not for Pagure, but I suppose we don't care 🙂

[mfocko]

Wouldn't it be easier to get last successful build? From the practical PoV I don't really see a difference between:

• checking commit by commit for a build
• taking last successful build

Or is the issue with different packages in the Copr repo? Can't we just filter by the package name in that case?

[nforro]

I think the problem is we need to get only builds triggered from the target branch of a PR. Although it would be weird to build in the same Copr project from different branches, it is possible.

[nforro]

I have opened packit/ogr#857.

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/f2c298f39e1a44a499e9141142836a0e

✔️ pre-commit SUCCESS in 2m 11s
✔️ packit-service-tests SUCCESS in 2m 35s

[nforro]

I decided to leave target_branch_head_commit there and use it first, since it should work in most cases and get_commits() could take some time, so it makes sense to call it only if necessary.

[lachmanfrantisek]

I think the problem is we need to get only builds triggered from the target branch of a PR. Although it would be weird to build in the same Copr project from different branches, it is possible.

We can use Build directories for this purpose. But this would require quite a lot of work.

[nforro]

We can use Build directories for this purpose. But this would require quite a lot of work.

Are you referring to this? I like the idea of having commit/release triggered builds in a project and PR builds in its subdirectories (I'm just starting to work on #2432), but I'm not sure if we should force users do configure that if they want to use OSH. Or maybe I just don't get your comment 🙂

[lbarcziova]

lgtm 👍

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/43cbef0fcfd24be8a7860307007209ed

✔️ pre-commit SUCCESS in 9m 19s