Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple implicit build → test relationship #1807

Open
TomasTomecek opened this issue Dec 14, 2022 · 5 comments
Open

Decouple implicit build → test relationship #1807

TomasTomecek opened this issue Dec 14, 2022 · 5 comments

Comments

@TomasTomecek
Copy link
Member

As we are heading in the direction of having multiple jobs that can consume artifacts from other (hello vm-image-build), we should decouple the implicit relationship of copr_build and tests jobs.

The expectation here is that:

@lachmanfrantisek
Copy link
Member

+1 for the decoupling, it will make the code really simpler!

  • /packit copr_build doesn't trigger tests

Hmm, I am wondering how to do this. And if this is really needed. (Test submission is done when we receive a build result.)

@TomasTomecek
Copy link
Member Author

TomasTomecek commented Dec 15, 2022

+1 for the decoupling, it will make the code really simpler!

  • /packit copr_build doesn't trigger tests

Hmm, I am wondering how to do this. And if this is really needed. (Test submission is done when we receive a build result.)

You are right! The point is, it should be configurable :) The "jobs referencing" should solve it.

@mfocko
Copy link
Member

mfocko commented Dec 15, 2022

+1 for the decoupling, it will make the code really simpler!

  • /packit copr_build doesn't trigger tests

Hmm, I am wondering how to do this. And if this is really needed. (Test submission is done when we receive a build result.)

Maybe we're getting to the point where job trigger is not actually a job trigger and we want job trigger and job source 😄 /s

ps: 🗡️ sounds good

@lachmanfrantisek
Copy link
Member

Maybe we're getting to the point where job trigger is not actually a job trigger and we want job trigger and job source smile /s

Exactly!
Do we want to solve that here? Or do this separately? (Since it's valid to all the downstream jobs as well.

@lachmanfrantisek
Copy link
Member

Still relevant but low prio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: backlog
Development

No branches or pull requests

3 participants