Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 128 bit constants in dpdk backend #5034

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maheswari-s
Copy link
Contributor

Added support for 128 bit constants usage in dpdk backend
Updated testcases and outputs

This PR overwrites the PR #5009

Sosutha and others added 2 commits November 18, 2024 23:32
Signed-off-by : Sosutha Sethuramapandian <[email protected]>

* Added support for 128 bit constants usage in dpdk backend
* Updated testcases and outputs
Copy link
Contributor

@psivanup psivanup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@maheswari-s
Copy link
Contributor Author

@fruffy , @syogender, @psivanup, @jafingerhut : Please review this PR for 128 bit implementation.
I addressed the issue raised by Andy in PR #5009. Addressed the issue as discussed with Cristian.

@fruffy fruffy added the dpdk Topics related to the DPDK back end label Nov 26, 2024
@jafingerhut
Copy link
Contributor

It looks like some expected output files are missing, according to the failure of the test-p4c-debian / test-ubuntu22 test report. Can you please add those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dpdk Topics related to the DPDK back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants