Fix recently failures because upstream P4C changes to cstrings and annotations. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fruffy Will you please take a look? |
|
The logic around https://github.com/p4gauntlet/toz3/pull/41/files#diff-dc7ce1551563fd6a0946f07c520318f7ec0e962400a9d17dc2b5c3413c33c44dR38 looks wrong to me, but I do not know the code to do proper fix :) |
asl
force-pushed
the
ann-fixes
branch
2 times, most recently
from
9405adc
to
134b9ab
Compare
|
Thanks for fixing these. I had started on this but didn't have the time to finish yet. The failure in the pruner is because of the changes to |
fruffy
changed the title
fruffy
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.