Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token factions should considere visibility status #22

Closed
CePeU opened this issue Nov 9, 2022 · 6 comments
Closed

Token factions should considere visibility status #22

CePeU opened this issue Nov 9, 2022 · 6 comments
Labels
enhancement New feature or request probably fixed

Comments

@CePeU
Copy link

CePeU commented Nov 9, 2022

If I give a color to tokens according to factions like friendly, enemy etc. token faction works great and enhances the overview I and the players have when a lot of icons are on the game board.

As a GM though I want to place new tokens on the board (ALT and draw an icon on the board) or I might make a token invisible when they lay in ambush. As a GM token factions helps to keep those token organized but as a player I should not be able to see those invisible icons. Token faction keeps drawing a faction color around those invisble tokens and thus reveals them.

A new setting "Show invisible faction colors only to GM" would be a nice improvement.

@CePeU CePeU added the enhancement New feature or request label Nov 9, 2022
@kevinbailey25
Copy link

Not sure if this is similar or not, but you can see the Token Factions through fog of war and when characters are not in line of sight. I couldn't find a setting or anything. Hope this could be added. Would be awesome to not show the factions unless the token itself is visible.

@amcvfx
Copy link

amcvfx commented Nov 22, 2022

I have the same issue. It used to only show the border for visible tokens but now all of them are visible. Border Control (which does a similar thing) also causes the same issue.

@p4535992
Copy link
Owner

The problem is fvtt10....and the new logic he implemented I was able to handle the use cases on the player side but unfortunately the GM when he checks a token will see the faction designs of the tokens.

img

Even with this "problem" now the module should be usable, unfortunately I am not a PIXI expert.

@amcvfx
Copy link

amcvfx commented Nov 24, 2022

Thanks for the update. This does fix all factions visible to players but unfortunately it doesn't display a faction until the player hovers over the token (except for their owned tokens). This is with just Token factions and libwrapper active.
tokenFactions

@p4535992
Copy link
Owner

p4535992 commented Dec 3, 2022

Should be finally fixed 0.3.8. Try out and let me know it.

@kevinbailey25
Copy link

kevinbailey25 commented Dec 3, 2022

Should be finally fixed 0.3.8. Try out and let me know it.

It's working perfectly! We had to cancel our last session where I was gonna use this due to a player being sick. So I'm super excited to be able to use it for our upcoming session.

Thanks so much for a great module!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request probably fixed
Projects
None yet
Development

No branches or pull requests

4 participants