Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hapi v17 Compatibility Release #18

Closed
3 tasks done
timcosta opened this issue Sep 26, 2017 · 7 comments
Closed
3 tasks done

Hapi v17 Compatibility Release #18

timcosta opened this issue Sep 26, 2017 · 7 comments

Comments

@timcosta
Copy link
Collaborator

timcosta commented Sep 26, 2017

Overview

If you are not aware yet, Hapi v17 is making the transition from callbacks to async/await. This is a breaking change that will make your plugin no longer compatible with the Hapi API.

Changelog

Draft release notes can be found here: hapijs/hapi#3658

Target Release

The target release date for v17 is the beginning of November.

Tasks

  • Reply to this to acknowledge that you are actively maintaining this module and are willing to update it
  • Update plugin to be fully async/await compatible using the v17 branch from Hapi for testing

    Possible dev flow for updating

    • Clone Hapi
    • npm link within the Hapi repo
    • npm link hapi within your plugin repo
    • Your plugin will now be using v17 of Hapi branch for tests
  • Release new major version of your plugin on npm. Please use a major version increment as this will be a breaking change and it would be terrible for it to sneak into current versions of Hapi.

Notes

  • Support is being dropped for all versions of Node <8.0.0.
  • Hapi v16 will continue to be supported for as long as there exists a Node LTS actively being supported that is not compatible with v17.
  • Targeted release date is November 1st, 2017. Please try to have your plugin updated before then.
@timcosta
Copy link
Collaborator Author

Will be updating

@gugwad
Copy link
Contributor

gugwad commented Dec 4, 2017

Any plan to update the plugin?

@gugwad
Copy link
Contributor

gugwad commented Dec 8, 2017

@timcosta Submitted a PR for transition to Hapi 17. Please review and comment. I will fix comments if any.

@timcosta
Copy link
Collaborator Author

@gugwad thanks for contributing the PR - I've been slammed at work recently and just haven't had the time. Left a few minor comments.

@gugwad
Copy link
Contributor

gugwad commented Dec 12, 2017

@timcosta Fixed review comments for PR.

@timcosta
Copy link
Collaborator Author

@gugwad your changes are now in master, thank you! Working on coordinating a release on npm with @p-meier.

@timcosta
Copy link
Collaborator Author

timcosta commented Dec 13, 2017

@gugwad

  npm publish
+ hapi-api-version@2.0.0

v2.0.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants