Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names for accessories are read, but not showing up properly. #156

Closed
stevenmcastano opened this issue Aug 14, 2018 · 6 comments
Closed

Names for accessories are read, but not showing up properly. #156

stevenmcastano opened this issue Aug 14, 2018 · 6 comments

Comments

@stevenmcastano
Copy link

As you can see from the attached screenshot, the names are there for my devices, but they still just show up as "Lightbulb" or "Outlet". Is there any way to display what's in the "name" field?

screen shot 2018-08-14 at 1 45 43 am

@stevenmcastano stevenmcastano changed the title Names for accessory are read, but not showing up. Names for accessories are read, but not showing up properly. Aug 14, 2018
@ElphaX
Copy link

ElphaX commented Aug 15, 2018

Have you named the accessory in the home app or your config.json file?

@stevenmcastano
Copy link
Author

They are named in the config.json file, I did not have to name anything in the Home app.

The config.json section that shows the names looks like this:

"renameDevices": [
                {
                    "nameContains": "Desk-BackLight",
                    "newName": "Desk Light"
                },
                {
                    "nameContains": "Kitchen-SLD",
                    "newName": "Kitchen"
                },
                {
                    "nameContains": "DR-Chandelier",
                    "newName": "Dining Room"
                },
                ......
                ......

I'm using the isy-js platform.

@oznu
Copy link
Member

oznu commented Aug 29, 2018

The plugin gets the default name from Characteristic.Name of the Accessory Service, which is the same behaviour as HomeKit.

In the screenshot provided the Accessory Service Characteristic.Name is either not set or is Lightbulb.

The Name shown in the information panel is from the Accessory Information Service not the Accessory Service. The Accessory Information Service is for the entire plugin, and since plugins can expose multiple accessories using this as the accessory name would result in many more errors.

@oznu
Copy link
Member

oznu commented Aug 29, 2018

The accessory information UI will eventually be expanded to allow the renaming of accessories.

@stevenmcastano
Copy link
Author

I was thinking it would be from the same place the Home app gets it's names... on my iPhone and iPad they are named correctly so it must be pulling the names from somewhere else.

Once being able to change the names in the UI comes out that will make things much better!! Also, a suggestion on layout would be to not have each room need to be an entirely new row. It would be nice if they could be grouped in boxes, but still be able to exist on the same row if there's room... otherwise I have to scroll down a ton just to separate things out.

@oznu
Copy link
Member

oznu commented Nov 2, 2018

3.9.0 provides the ability to give an accessory a custom name.

@oznu oznu closed this as completed Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants