Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actionlint error in GitHub Action workflows #3052

Closed
wants to merge 1 commit into from

Conversation

ashokm
Copy link
Contributor

@ashokm ashokm commented Oct 30, 2023

Fixes actionlint error in GitHub Action workflows:

"if: condition "${{ success() }} || ${{ failure() }}" is always evaluated to true because extra characters are around ${{ }} [if-cond]"

Fixes "if: condition "${{ success() }} || ${{ failure() }}" is always evaluated to true because extra characters are around ${{ }} [if-cond]"
@ashokm ashokm temporarily deployed to dev October 30, 2023 12:09 — with GitHub Actions Inactive
@ashokm ashokm temporarily deployed to dev October 30, 2023 12:09 — with GitHub Actions Inactive
@echoix
Copy link
Collaborator

echoix commented Oct 30, 2023

See #3026 for a complete refactoring of the templates, that addresses this, but wasn't completely ready this weekend for the release.

@ashokm
Copy link
Contributor Author

ashokm commented Oct 30, 2023

@echoix , ah I see that the Issue you linked (which aimed to resolve a Checkov permssion error) has evolved in the associated development PR #3032 to also address what I have attempted to include. I'll close my PR.

@ashokm ashokm closed this Oct 30, 2023
@ashokm ashokm deleted the fix-actionlint-error branch October 30, 2023 12:36
@echoix
Copy link
Collaborator

echoix commented Oct 30, 2023

And if you take a look at that new PR, I hope you'll find that the new template is way better than the old one.
If there's anything missing, add a review comment with the changes as suggestions, we'll apply it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants