Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintained version of misspell #2823

Closed
girlpunk opened this issue Jul 20, 2023 · 9 comments
Closed

Maintained version of misspell #2823

girlpunk opened this issue Jul 20, 2023 · 9 comments
Labels
enhancement New feature or request O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity

Comments

@girlpunk
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Misspell was previously removed as the original version, by client9, is not maintained. However, misspell provides a significantly better spelling check for code (such as variable names, etc) than any other linter offered by megalinter.

Describe the solution you'd like
Golang are maintaining a fork of misspell at golangci/misspell. As such, I would like to suggest re-introducing misspell but from this fork rather than the original.

Describe alternatives you've considered
None

Additional context
None

@girlpunk girlpunk added the enhancement New feature or request label Jul 20, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Aug 20, 2023
@girlpunk
Copy link
Contributor Author

Still outstanding

@nvuillam
Copy link
Member

@girlpunk the repo is still a fork, usually a hard-fork cuts links with the origin repo and announces it, do you think it would be possible that golang do that ?

@girlpunk
Copy link
Contributor Author

I'm not sure unfortunately, beyond making use of it I don't have any relation with the fork.

@nvuillam
Copy link
Member

@girlpunk if you post an issue there they might confirm what I need ? :)
As MegaLinter is heavily used by bigger companies, and can't natively add a fork with 6 stars that is not officially maintained, so the alternative would be to build a MegaLinter plugin (by just resurrecting the previous content of MegaLinter internal descriptor )

@girlpunk
Copy link
Contributor Author

Looks like they do intend to

golangci/misspell#4 (comment)

@ldez
Copy link

ldez commented Aug 21, 2023

Hello,

As you are using golangci-lint you are using already using our fork of misspell 😄

Hard forks are rare (at least on GitHub), we don't need to do that and it's weird regarding the original author.
Also being a "soft" fork allow users who are looking for a maintained fork to show our fork.

@github-actions github-actions bot removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Aug 22, 2023
@nvuillam
Copy link
Member

nvuillam commented Aug 22, 2023

@ldez thanks for the precision :)

You might add in the README that you maintain this fork as the original repo is abandonware, so next person who wants to use it will already know ^^

Ps: cocorico 🐓

@girlpunk misspell is so eligible to be back within MegaLinter, would you like to make the PR ? :)

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Sep 22, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity
Projects
None yet
Development

No branches or pull requests

3 participants