From d7fb45361806eb47e844128650ae5de2831ffabc Mon Sep 17 00:00:00 2001 From: Megan Warres Date: Tue, 4 Oct 2022 11:58:57 -0700 Subject: [PATCH] Fix Docker container names in pre-commit hooks The previous Docker container names contained Bash syntax, but pre-commit interprets them as string literals, resulting in invalid Docker container names. Remove Bash syntax, and replace it with string literals. --- .pre-commit-hooks.yaml | 4 ++-- CHANGELOG.md | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.pre-commit-hooks.yaml b/.pre-commit-hooks.yaml index d9aa313e8a4..d1ae481fd9a 100644 --- a/.pre-commit-hooks.yaml +++ b/.pre-commit-hooks.yaml @@ -5,7 +5,7 @@ require_serial: true args: - mega-linter-runner - - --container-name "megalinter-$(basename "$PWD")" + - --containername megalinter-incremental - --remove-container - --fix - --env @@ -35,7 +35,7 @@ require_serial: true args: - mega-linter-runner - - --container-name "megalinter-all-$(basename "$PWD")" + - --containername megalinter-full - --remove-container - --fix - --env diff --git a/CHANGELOG.md b/CHANGELOG.md index 9b904c0c1ac..82c4064146b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), Note: Can be used with `oxsecurity/megalinter@beta` in your GitHub Action mega-linter.yml file, or with `oxsecurity/megalinter:beta` docker image +- Fix invalid Docker container names in .pre-commit-hooks.yaml ([#1932](https://github.com/oxsecurity/megalinter/issues/1932)) - Correct removeContainer casing in runner ([#1917](https://github.com/oxsecurity/megalinter/issues/1917)) + - Linter versions upgrades - [cfn-lint](https://github.com/aws-cloudformation/cfn-lint) from 0.66.0 to **0.66.1** on 2022-10-04 - [mypy](https://mypy.readthedocs.io/en/stable/) from 0.981 to **0.982** on 2022-10-04