Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix binary wheel building & uploading to pypi #15

Closed
ctb opened this issue Sep 9, 2024 · 9 comments
Closed

fix binary wheel building & uploading to pypi #15

ctb opened this issue Sep 9, 2024 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@ctb
Copy link
Contributor

ctb commented Sep 9, 2024

No description provided.

@Adamtaranto Adamtaranto added the bug Something isn't working label Sep 20, 2024
@Adamtaranto
Copy link
Collaborator

Had another look at this, not sure what is wrong with CI.yml workflow.

Have you set up the PyPi token for this project?

@ctb
Copy link
Contributor Author

ctb commented Sep 23, 2024

Followed https://docs.pypi.org/trusted-publishers/adding-a-publisher/, and added GitHub oxli-bio/oxli as a trusted publisher:

Screenshot 2024-09-22 at 5 55 58 PM

Shall we try to cut a new release once #31 and #45 are merged, and see if it works?

Hmm, maybe I actually enabled trusted publishing instead of token auth 🤔 - see:

Screenshot 2024-09-22 at 5 58 37 PM

Also, what's your pypi username?

@Adamtaranto
Copy link
Collaborator

pypi username is adamtaranto

@Adamtaranto
Copy link
Collaborator

Good to go on making a new release

@ctb
Copy link
Contributor Author

ctb commented Sep 23, 2024

well, it is now running the right thing :) but now says:

💥 maturin failed
Caused by: Credentials not found and non-interactive mode is enabled

@ctb
Copy link
Contributor Author

ctb commented Sep 23, 2024

(this was also a useful link for getting the YAML right in the CI release section: https://docs.pypi.org/trusted-publishers/using-a-publisher/)

@ctb
Copy link
Contributor Author

ctb commented Sep 23, 2024

It worked! Now to test it out on a real release...

@ctb
Copy link
Contributor Author

ctb commented Sep 23, 2024

@ctb
Copy link
Contributor Author

ctb commented Sep 23, 2024

v0.3.0 released and uploaded to PyPI! Now to see if conda-forge picks it up :)

https://pypi.org/project/oxli/#files

@ctb ctb closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants