Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this package extend NetworkLayouts.jl? #44

Open
asinghvi17 opened this issue Dec 5, 2024 · 1 comment
Open

Should this package extend NetworkLayouts.jl? #44

asinghvi17 opened this issue Dec 5, 2024 · 1 comment

Comments

@asinghvi17
Copy link

That would make it a drop-in replacement for graph layout algorithms in e.g GraphMakie.jl. The only change that would be needed are:

  • The solvers inherit from NetworkLayout.AbstractLayout
  • The solver structs are themselves callable and return vectors of GeometryBasics.Point2

For this, we'd have to add three new fields to the Zarate struct that correspond to the kwargs in the current solve_positions function. But this wouldn't technically be breaking from a user perspective, since that function's kwargs can still override the solver specification if desired.

What do you think @oxinabox? I'm happy to put in a PR if you think this makes sense.

@oxinabox
Copy link
Owner

oxinabox commented Dec 5, 2024

I think that makes sense.
NetworkLayouts is fairly lightweight.

Maybe we want to make a struct (ZarateLayout) that wraps the current struct.
So existing uses don't have to change at all.

I would review such a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants