Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display download progress bar #153

Open
CarloLucibello opened this issue May 9, 2022 · 2 comments
Open

display download progress bar #153

CarloLucibello opened this issue May 9, 2022 · 2 comments

Comments

@CarloLucibello
Copy link
Contributor

It is useful when downloading large datasets.

@oxinabox
Copy link
Owner

Do you mean for 1 file or for multiple files?
For 1 file this issue needs to be openned on HTTP.jl as we use HTTP.download to do the download.
(unless you pass in a different fetch_method)
When I updated HTTP.download I had progress logging working: https://github.com/JuliaWeb/HTTP.jl/blob/7cab2ab077825aff366cc8e1e34db9d5566654bd/src/download.jl#L134
AFAICT It is still ProgressLogging.jl compatible.
Which means if you use Juno (pretty sure i tested this) or TerminalLoggers.jl a progress bar will show up rather than a %

For multiple files we could display a progress bar for the overall, in this package.

@TheCedarPrince
Copy link

TheCedarPrince commented Sep 8, 2022

Hey @oxinabox,

I opened an issue over HTTP.jl - hopefully I didn't butcher what you were discussing here but I would find this feature quite helpful. Thanks for the great package again!

P.S. Hopefully this addresses the comments also found in #145 #114 and #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants