Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to silence 7zip output #142

Open
arnaudh opened this issue Jul 28, 2021 · 3 comments · May be fixed by #143
Open

Ability to silence 7zip output #142

arnaudh opened this issue Jul 28, 2021 · 3 comments · May be fixed by #143

Comments

@arnaudh
Copy link

arnaudh commented Jul 28, 2021

This is a minor feature request, but it would be nice to be able to silence the outputs of 7zip.

Currently seeing this when downloading/extracting a datadep:

7-Zip (a) [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21
--
p7zip Version 16.02 (locale=C,Utf16=off,HugeFiles=on,64 bits,4 CPUs Intel(R) Xeon(R) CPU E5-2686 v4 @ 2.30GHz (406F1),ASM,AES-NI)
Scanning the drive for archives:
1 file, 752601330 bytes (718 MiB)
Extracting archive: /root/.julia/datadeps/XXX/XXX.zip
--
Path = /root/.julia/datadeps/XXX/XXX.zip
Type = zip
Physical Size = 752601330
Everything is Ok
Folders: 2
Files: 48
Size:       9319283882
Compressed: 752601330

Seems like we could use the 7zip -bs switch like so: -bso0 -bsp0. This would disable standard output messages and progress information, while keeping error messages.

@oxinabox
Copy link
Owner

Making it configurable is annoying for everyone.
We should pick the right thing and do that always.
Is the right thing to always do -bso0 -bsp0?
I could easily be convinced of that.
PR would be appreciated

@arnaudh
Copy link
Author

arnaudh commented Jul 29, 2021

Is the right thing to always do -bso0 -bsp0?

I would say so. Knowing what compression software is used is an implementation detail of DataDeps, and as a user I only want to know if there was a failure (happy case should be silent, or perhaps a one-line statement e.g. "Datadep extracted to XXX").

I'll create a PR if you are convinced 🙂

@oxinabox
Copy link
Owner

Sounds good to me

@arnaudh arnaudh linked a pull request Jul 30, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants