Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemars deprecated schemas #737

Open
jeroenvervaeke opened this issue Jan 12, 2025 · 1 comment
Open

schemars deprecated schemas #737

jeroenvervaeke opened this issue Jan 12, 2025 · 1 comment

Comments

@jeroenvervaeke
Copy link

schemars deprecated a lot of types for 1.0.0

Changelog:
https://github.com/GREsau/schemars/blob/master/CHANGELOG.md#removed-%EF%B8%8F-breaking-changes-%EF%B8%8F-1

Removed types:

  • RootSchema
  • SchemaObject
  • Metadata
  • SubschemaValidation
  • NumberValidation
  • StringValidation
  • ArrayValidation
  • ObjectValidation
  • InstanceType
  • SingleOrVec

I'm thinking about adding the types to this crate and remove the dependency on schemars.

Would this change be welcome?
If so I'll implement it.

@ahl
Copy link
Collaborator

ahl commented Jan 19, 2025

Agreed that we'll need a solution if we migrate off of schemars. In exploring this, I've observed that there's significant opportunity to improve upon the types from schemars. I've been exploring generating the types using the schema files for various JSON Schema drafts in a sort of bootstrapping mode for typify. This work is wrapped up with a prototype for multi-file support, improved errors, etc.

While the offer is appreciated, I'll decline for now. And even when schemars 1.0 does come out, I think that typify can safely stay with 0.8. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants