Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add documentation on pre and post hooks to builder methods #934

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

add documentation on pre and post hooks to builder methods #934

wants to merge 6 commits into from

Conversation

upachler
Copy link
Contributor

@upachler upachler commented Oct 4, 2024

I took the liberty and added some docs, hope this meets the requirements.

This was referenced Oct 4, 2024
Open
Merged
@ahl
Copy link
Collaborator

ahl commented Nov 25, 2024

Let's update this in light of #933?

@upachler
Copy link
Contributor Author

upachler commented Nov 26, 2024 •
edited
Loading

Hi @ahl, I adapted the docs as promised. However, apparently cargo fmt -- --check is now complaining about style (see below) - but I can't see anything wrong. When run locally, there is no output. I'm puzzled. Any clues? Or is this a Windows/Linux thing (I'm using a Windows machine ATM).

@ahl
Copy link
Collaborator

ahl commented Nov 26, 2024

You can run cargo fmt and it will fix things. In this case, you have trailing spaces at the end of some lines.

@upachler
Copy link
Contributor Author

ok thanks, seems that did it

@upachler
Copy link
Contributor Author

@ahl: IMHO this should be ready to merge, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@upachler @ahl