-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic while generating YNAB OpenAPI client #693
Comments
The part of the spec it's barfing on is here: responses:
"200":
description: The requested category
content:
application/json:
schema:
$ref: "#/components/schemas/CategoryResponse"
"404":
description: The category not was found
content:
application/json:
schema:
$ref: "#/components/schemas/ErrorResponse"
default:
description: An error occurred
content:
application/json:
schema:
$ref: "#/components/schemas/ErrorResponse" In short, this says, "200s will return a CategoryResponse; 404s will return ErrorResponse; and everything else will return ErrorResponse". Where we get hung up is that "everything else". If that's inclusive of success responses (say, a 201 or 202) should we expect to get Given the ambiguity here and this common practice, I think we may want to change the interpretation to conform to the common law use of OpenAPI rather than its by-the-letter writing. So something like:
|
See #344 |
Hi there!
I tried to generate a client for the YNAB OpenAPI spec which seems to panic:
The text was updated successfully, but these errors were encountered: