end-to-end tests could use external DNS and real authn #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7b023b5.
luqmana
reviewed
May 2, 2023
| // Nexus's external IP address from the external DNS server. So we'd | ||
| // expect Nexus to be up. But that's not necessarily true: external DNS can | ||
| // be set up during rack initialization, before Nexus has opened its | ||
| // external listening socket. This is arguably a bug, advertising a service |
There was a problem hiding this comment.
Should we create an issue to track that? I know the rack/service initialization process could still use some polish.
There was a problem hiding this comment.
You mean to track the behavior that Nexus publishes its addresses to DNS before it's opened its listening socket? I'm not clear that's a bug but I'm happy to file an issue to document it and/or have that discussion.
There was a problem hiding this comment.
If the expectation is that we should only be adding the DNS records once the service is up then seems we should have an issue tracking that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #2943, this updates the end-to-end tests to use the external DNS server to locate Nexus. They also now use password-based authn using the user created during rack setup, just as a customer will do. (Previously the tests used "spoof" authn with the built-in "test-privileged" user.)
Depends on #2943.