Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idp_entity_id is redundant in Saml IdP creation payload #3049

Open
luqmana opened this issue May 8, 2023 · 1 comment
Open

idp_entity_id is redundant in Saml IdP creation payload #3049

luqmana opened this issue May 8, 2023 · 1 comment

Comments

@luqmana
Copy link
Contributor

luqmana commented May 8, 2023

We could simplify the SAML IdP creation payload a little bit. Today it looks like:

pub struct SamlIdentityProviderCreate {
#[serde(flatten)]
pub identity: IdentityMetadataCreateParams,
/// the source of an identity provider metadata descriptor
pub idp_metadata_source: IdpMetadataSource,
/// idp's entity id
pub idp_entity_id: String,
/// sp's client id
pub sp_client_id: String,
/// service provider endpoint where the response will be sent
pub acs_url: String,
/// service provider endpoint where the idp should send log out requests
pub slo_url: String,
/// customer's technical contact for saml configuration
pub technical_contact_email: String,
/// request signing key pair
#[serde(default)]
#[serde(deserialize_with = "validate_key_pair")]
pub signing_keypair: Option<DerEncodedKeyPair>,
/// If set, SAML attributes with this name will be considered to denote a
/// user's group membership, where the attribute value(s) should be a
/// comma-separated list of group names.
pub group_attribute_name: Option<String>,
}

idp_entity_id is available as the entityID attribute on the root EntityDescriptor node from the IdP metadata XML.

@jmpesp
Copy link
Contributor

jmpesp commented Jul 20, 2023

It may also be possible to generate both acs_url and slo_url, though it may be better for those to be optional so they can be overridden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants