-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some named objects in DB lacking UNIQUE name index #2124
Comments
Good call! For saml_identity_provider, I think the index needs to be there. We do expect multiple IdPs in a Silo and they should not have overlapping names. For saga, I think it's fine as is. As you said, the name is not a unique identifier for these. |
See also #1534 |
#3530 addresses the That leaves |
I believe
Of course floating IPs still need to be fully fleshed out (#1334). But we do create some floating external IP records today for external services like Nexus & External DNS which need inbound connectivity. But those don't really fit into the scheme described by the RFD as the |
Some objects in the DB have a name, and a corresponding index to ensure the name remains unique.
For example:
The following objects within the database have a
name
field, but noUNIQUE
index on the name:id
+silo_id
, but no name-based index. This might be fine, if the assumption exists that "only one can ever exist within the scope of a silo anyway".floating
ips. I believe this means that multiple floating IPs could exist with the same name.The text was updated successfully, but these errors were encountered: