Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VPC name a link, use one-offs to avoid dire type situation #1063

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

david-crespo
Copy link
Collaborator

It is very annoying that TS doesn't make the generic version easy. We're fighting this all the time. This is usually where I end up.

@vercel
Copy link

vercel bot commented Jul 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
console-ui-storybook ✅ Ready (Inspect) Visit Preview Jul 20, 2022 at 10:18PM (UTC)

@david-crespo david-crespo requested a review from zephraph July 20, 2022 22:18
@zephraph zephraph merged commit 03f3cb4 into add-nic-details Jul 21, 2022
@zephraph zephraph deleted the vpc-name-link branch July 21, 2022 08:31
zephraph added a commit that referenced this pull request Jul 21, 2022
* WIP

* Slightly more correct types

* Fix indirect export issue

* Add ts-expect-errors for now

* Fix e2e tests

* Fix e2e take 2

* Remove table debug

* fix merge conflict I rudely introduced

* make vpc name a link, avoid dire type situation (#1063)

Co-authored-by: David Crespo <[email protected]>
Co-authored-by: David Crespo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants