Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instance create] Include attached disks in POST body #732

Closed
david-crespo opened this issue Mar 25, 2022 · 0 comments · Fixed by #760
Closed

[Instance create] Include attached disks in POST body #732

david-crespo opened this issue Mar 25, 2022 · 0 comments · Fixed by #760
Assignees
@zephraph

Comments

@david-crespo
Copy link
Collaborator

david-crespo commented Mar 25, 2022 •
edited
Loading

We have a modal for adding an existing disk, but we need to batch up the list of disks to attach and include it with the POST under the disks key. oxidecomputer/omicron#771 added to the instance create POST body a list of disk names to attach. OpenAPI spec here.
@david-crespo david-crespo mentioned this issue Mar 25, 2022
Closed
@david-crespo david-crespo changed the title Include attached disks in instance create POST [Instance create] Include attached disks in POST body Mar 25, 2022
@david-crespo david-crespo mentioned this issue Mar 25, 2022
Closed
@zephraph zephraph self-assigned this Mar 25, 2022
@zephraph zephraph mentioned this issue Apr 5, 2022
Merged
@zephraph zephraph linked a pull request Apr 5, 2022 that will close this issue
Convert instance form #760
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zephraph zephraph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert instance form oxidecomputer/console
2 participants
@zephraph @david-crespo