Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use min() for modal top position #2523

Open
benjaminleonard opened this issue Oct 29, 2024 · 0 comments · May be fixed by #2583
Open

Use min() for modal top position #2523

benjaminleonard opened this issue Oct 29, 2024 · 0 comments · May be fixed by #2583

Comments

@benjaminleonard
Copy link
Contributor

On taller screens the modal seems like it comes down a bit far (at 50%). Also, if the height of the modal changes (with some dynamic content) at all the position of say an input will no longer be where it was previously.

We could use min() – that way we make it a fixed position at the top and then have it snap to 50% if the modal moves to a threshold.

Image

@benjaminleonard benjaminleonard linked a pull request Nov 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant