Refactored the 'RecipientState' type and other improvements #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mpretty-cyro
commented
Oct 18, 2024
mpretty-cyro
commented
- Refactored the 'RecipientState' type to just be columns on the 'Interaction' table
- Added some syntactic sugar to clean up the 'CallbackWrapper' boilerplate within the LibSession+Networking code
- Fixed an issue where sending a message into a group where you are the only member would result in the message permanently being in the sending state
- Fixed an issue when initially setting up the interaction database structure where the community whisper mechanism needed another column
- Fixed a bug where the MessageSendJob wouldn't time out during path building
- Fixed a bug where the MessageSendJob wouldn't retry 8 times before detecting a timeout (meaning it would retry up to 80 times in total before permanently failing)
• Refactored the 'RecipientState' type to just be columns on the 'Interaction' table • Added some syntactic sugar to clean up the 'CallbackWrapper' boilerplate within the LibSession+Networking code • Fixed an issue where sending a message into a group where you are the only member would result in the message permanently being in the sending state • Fixed an issue when initially setting up the interaction database structure where the community whisper mechanism needed another column • Fixed a bug where the MessageSendJob wouldn't time out during path building • Fixed a bug where the MessageSendJob wouldn't retry 8 times before detecting a timeout (meaning it would retry up to 80 times in total before permanently failing)
mpretty-cyro
changed the title
RyanRory
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.