Revert "fix(website): incorrect reference displayed" #4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
What did the original PR break? |
DonIsaac
approved these changes
Jul 28, 2024
Merge activity
|
DonIsaac
pushed a commit
that referenced
this pull request
Jul 28, 2024
DonIsaac
force-pushed
the
revert-4453-07-25-fix_website_incorrect_reference_displayed
branch
from
63ce8b9 to
be169ef
Compare
DonIsaac
force-pushed
the
revert-4453-07-25-fix_website_incorrect_reference_displayed
branch
from
be169ef to
b1b66e2
Compare
graphite-app
bot
deleted the
revert-4453-07-25-fix_website_incorrect_reference_displayed
branch
It didn't break anything, it was correct. Problem was that #4467 changed the numbering of scope IDs so that the original code was correct again! Sorry I didn't spot this at the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4453
#4467 changes reference_id to zero-based index 😅