Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(semantic): reduce storage size for symbol redeclarations #4463

Merged
merged 1 commit into from
Jul 26, 2024
Merged

perf(semantic): reduce storage size for symbol redeclarations #4463

merged 1 commit into from
Jul 26, 2024

Commits on Jul 26, 2024

  1. perf(semantic): reduce storage size for symbol redeclarations (#4463) 

    Most symbols don't have redeclarations.

So instead of storing `Vec<Span>` directly in `redeclare_variables` (24 bytes per symbol), store `Option<RedeclarationId>` (4 bytes).

`RedeclarationId` indexes into `redeclarations` where the actual `Vec<Span>` is stored. But for symbols with no redeclarations (the vast majority), it takes 4 bytes per symbol only.
    @overlookmotel
    overlookmotel committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6a9f4db View commit details
    Browse the repository at this point in the history