Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining problems for class properties transform #7730

Open
2 of 15 tasks
overlookmotel opened this issue Dec 8, 2024 · 0 comments
Open
2 of 15 tasks

Remaining problems for class properties transform #7730

overlookmotel opened this issue Dec 8, 2024 · 0 comments
Assignees
Labels
A-transformer Area - Transformer / Transpiler

Comments

@overlookmotel
Copy link
Contributor

overlookmotel commented Dec 8, 2024

Remaining issues:

Correctness

In order of how likely they are to affect real world code:

  • Co-ordinate class properties transform with TS transform.
  • Run other transforms on inserted statements.
  • Variable collisions between instance prop initializers and constructor.
  • Transform super in static prop initializers.
  • Replace class name with temp var in static blocks.
  • Shadowed class name in transpiled static private field (e.g. private/static-shadow/input.js fixture).
  • _super function outside class means super.foo in prop initializers needs to be transformed.
  • Infer name of class expressions.
  • TDZ violations in computed keys - referring to class name within computed key.

The last 3 are very unlikely to have real-world impact.

Improvements / optimizations / required to pass tests

Other

  • Handful of other small issues noted in TODO comments in implementation code.
@overlookmotel overlookmotel added the C-bug Category - Bug label Dec 8, 2024
@overlookmotel overlookmotel added this to the Transformer Milestone 2 milestone Dec 8, 2024
@overlookmotel overlookmotel added A-transformer Area - Transformer / Transpiler and removed C-bug Category - Bug labels Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

No branches or pull requests

1 participant