Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply #[ast] macro to AST types in oxc_syntax crate #4623

Closed
overlookmotel opened this issue Aug 3, 2024 · 0 comments
Closed

Apply #[ast] macro to AST types in oxc_syntax crate #4623

overlookmotel opened this issue Aug 3, 2024 · 0 comments
Labels
A-ast Area - AST

Comments

@overlookmotel
Copy link
Contributor

overlookmotel commented Aug 3, 2024

#4614 made all AST types in oxc_ast crate #[repr(C)] via the #[ast] macro.

We still need to apply #[ast] macro to types in oxc_syntax crate which are part of AST e.g. AssignmentOperator.

We could also put #[ast] on oxc_span::Span. Or we may just want to put #[repr(C)] on it, and hard-code the layout into AST codegen, since Span is such a simple type.

I don't think there are any other AST types in other crates - apart from Atom, Vec and Box, which we treat as special cases.

@overlookmotel overlookmotel added the A-ast Area - AST label Aug 3, 2024
@rzvxa rzvxa closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST
Projects
None yet
Development

No branches or pull requests

2 participants