Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: Remove TSParenthesizedType #4251

Closed
Boshen opened this issue Jul 14, 2024 · 1 comment
Closed

codegen: Remove TSParenthesizedType #4251

Boshen opened this issue Jul 14, 2024 · 1 comment

Comments

@Boshen
Copy link
Member

Boshen commented Jul 14, 2024

I'm on the same boat right now, introducing TSParenthesizedType to get everything printed correctly on the main branch.

before removing the TSParenthesizedType node, I need to

  • add more test coverage for ts codegen
  • understand how to print parenthesis on ts types properly
  • port the reference implementation from typescript compile

Originally posted by @Boshen in #4245 (comment)
@Boshen
Copy link
Member Author

Boshen commented Aug 1, 2024

Don't have the bandwidth right now.

@Boshen Boshen closed this as completed Aug 1, 2024
@Boshen Boshen closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Boshen