Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few panics when checking and fixing specific files #4212

Closed
qarmin opened this issue Jul 11, 2024 · 5 comments
Closed

Few panics when checking and fixing specific files #4212

qarmin opened this issue Jul 11, 2024 · 5 comments
Labels
C-bug Category - Bug

Comments

@qarmin
Copy link

qarmin commented Jul 11, 2024

Command

"oxlint" "-D" "all" "-D" "nursery" "TEST___FILE.js" "--fix"

some of problems are visible on debug builds

Files - Untitled Folder.zip

Example of problems

thread '<unnamed>' panicked at crates/oxc_span/src/span.rs:102:9:
attempt to subtract with overflow
thread '<unnamed>' panicked at crates/oxc_linter/src/utils/tree_shaking.rs:424:41:
attempt to shift right with overflow
thread '<unnamed>' panicked at crates/oxc_linter/src/utils/tree_shaking.rs:450:41:
attempt to shift left with overflow
thread '<unknown>' has overflowed its stack
fatal runtime error: stack overflow

Edit:
Out of memory - compressed.zip
Not a char boundary - compressed.zip

@qarmin qarmin added the C-bug Category - Bug label Jul 11, 2024
@Boshen
Copy link
Member

Boshen commented Jul 12, 2024

Thank you again! Is there a way that we can setup continuous fuzzing? I can setup a repo for you. I had one using shift-fuzzer https://github.com/oxc-project/oxc-fuzz-parser, and another here https://github.com/oxc-project/oxc/blob/main/.github/workflows/fuzz.yml

@qarmin
Copy link
Author

qarmin commented Jul 13, 2024

To find bugs I'm using https://github.com/qarmin/Automated-Fuzzer

It is mainly an internal tool that I use to test various libraries.
"Internal" because no one except me is using it and I change the code quite often.
New programs have to be added from the rust side and also some of the parameters are not available in configuration files by requires changing the code in the rust

Still, it would be possible to use some specific commit from this repo and copy the almost unchanged workflow file https://github.com/qarmin/Automated-Fuzzer/blob/master/.github/workflows/oxc.yml and settings file https://github.com/qarmin/Automated-Fuzzer/blob/master/fuzz_oxc_settings_ci.toml to get fully working fuzzer in CI - https://github.com/qarmin/Automated-Fuzzer/actions/runs/9914718347

There are also some hardcoded exceptions to avoid currently not fixed problems - https://github.com/qarmin/Automated-Fuzzer/blob/master/src/apps/oxc.rs#L15-L20

@Boshen
Copy link
Member

Boshen commented Jul 13, 2024

@qarmin I really like your automation. I think duplicating the workflow here is unnecessary, what about creating an issue on your side and assign the issue to me automatically via something like https://github.com/JasonEtco/create-an-issue?

@qarmin
Copy link
Author

qarmin commented Aug 4, 2024

I have not been able to do something like this, because everything would have to be reviewed manually anyway, and a mass of duplicates would be created, so it will be easier if I manually report each error in a separate issue - I do not think there will be a lot of them.

@qarmin qarmin closed this as completed Aug 4, 2024
@Boshen
Copy link
Member

Boshen commented Aug 4, 2024

I have not been able to do something like this, because everything would have to be reviewed manually anyway, and a mass of duplicates would be created, so it will be easier if I manually report each error in a separate issue - I do not think there will be a lot of them.

Thank you, appreciate your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category - Bug
Projects
None yet
Development

No branches or pull requests

2 participants