From c5731a54314cf2a0c690c07bebb68aca6ec0fb70 Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Tue, 16 Jul 2024 07:32:36 +0000
Subject: [PATCH] refactor(semantic): remove defunct code setting ScopeFlags
 twice (#4286)

Scope flags for functions is set when the scope is created. Remove redundant code that sets them again.
---
 crates/oxc_semantic/src/binder.rs | 32 ++++++++++---------------------
 1 file changed, 10 insertions(+), 22 deletions(-)

diff --git a/crates/oxc_semantic/src/binder.rs b/crates/oxc_semantic/src/binder.rs
index 28612911cff41..b268a913cd054 100644
--- a/crates/oxc_semantic/src/binder.rs
+++ b/crates/oxc_semantic/src/binder.rs
@@ -151,28 +151,16 @@ impl<'a> Binder for Function<'a> {
             }
         }
 
-        // bind scope flags: Constructor | GetAccessor | SetAccessor
-        if let Some(kind) = builder.nodes.parent_kind(builder.current_node_id) {
-            match kind {
-                AstKind::MethodDefinition(def) => {
-                    let flag = builder.scope.get_flags_mut(current_scope_id);
-                    *flag |= match def.kind {
-                        MethodDefinitionKind::Constructor => ScopeFlags::Constructor,
-                        MethodDefinitionKind::Get => ScopeFlags::GetAccessor,
-                        MethodDefinitionKind::Set => ScopeFlags::SetAccessor,
-                        MethodDefinitionKind::Method => ScopeFlags::empty(),
-                    };
-                }
-                AstKind::ObjectProperty(prop) => {
-                    let flag = builder.scope.get_flags_mut(current_scope_id);
-                    *flag |= match prop.kind {
-                        PropertyKind::Get => ScopeFlags::GetAccessor,
-                        PropertyKind::Set => ScopeFlags::SetAccessor,
-                        PropertyKind::Init => ScopeFlags::empty(),
-                    };
-                }
-                _ => {}
-            }
+        // Bind scope flags: GetAccessor | SetAccessor
+        if let Some(AstKind::ObjectProperty(prop)) =
+            builder.nodes.parent_kind(builder.current_node_id)
+        {
+            let flag = builder.scope.get_flags_mut(current_scope_id);
+            match prop.kind {
+                PropertyKind::Get => *flag |= ScopeFlags::GetAccessor,
+                PropertyKind::Set => *flag |= ScopeFlags::SetAccessor,
+                PropertyKind::Init => {}
+            };
         }
     }
 }