diff --git a/crates/oxc_semantic/src/checker/typescript.rs b/crates/oxc_semantic/src/checker/typescript.rs index 0c4b6637e0b1a..28c263a01462e 100644 --- a/crates/oxc_semantic/src/checker/typescript.rs +++ b/crates/oxc_semantic/src/checker/typescript.rs @@ -112,11 +112,11 @@ fn unexpected_type_annotation(span0: Span) -> OxcDiagnostic { pub fn check_array_pattern<'a>(pattern: &ArrayPattern<'a>, ctx: &SemanticBuilder<'a>) { for element in &pattern.elements { - let _ = element.as_ref().map(|element| { + if let Some(element) = element.as_ref() { if let Some(type_annotation) = &element.type_annotation { ctx.error(unexpected_type_annotation(type_annotation.span)); } - }); + } } } diff --git a/crates/oxc_semantic/src/scope.rs b/crates/oxc_semantic/src/scope.rs index 379c457542158..41b61b53e2c1b 100644 --- a/crates/oxc_semantic/src/scope.rs +++ b/crates/oxc_semantic/src/scope.rs @@ -198,10 +198,10 @@ impl ScopeTree { flags: ScopeFlags, ) -> ScopeId { let scope_id = self.parent_ids.push(parent_id); - _ = self.child_ids.push(vec![]); - _ = self.flags.push(flags); - _ = self.bindings.push(Bindings::default()); - _ = self.node_ids.push(node_id); + self.child_ids.push(vec![]); + self.flags.push(flags); + self.bindings.push(Bindings::default()); + self.node_ids.push(node_id); // Set this scope as child of parent scope. if let Some(parent_id) = parent_id { diff --git a/crates/oxc_semantic/src/symbol.rs b/crates/oxc_semantic/src/symbol.rs index 80bc798c1a0fa..d485439250b1c 100644 --- a/crates/oxc_semantic/src/symbol.rs +++ b/crates/oxc_semantic/src/symbol.rs @@ -120,11 +120,11 @@ impl SymbolTable { flag: SymbolFlags, scope_id: ScopeId, ) -> SymbolId { - _ = self.spans.push(span); - _ = self.names.push(name); - _ = self.flags.push(flag); - _ = self.scope_ids.push(scope_id); - _ = self.resolved_references.push(vec![]); + self.spans.push(span); + self.names.push(name); + self.flags.push(flag); + self.scope_ids.push(scope_id); + self.resolved_references.push(vec![]); self.redeclare_variables.push(vec![]) }