From 54ef2b9e185ec70b6e51a00e653964b9b6020960 Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Wed, 11 Dec 2024 14:54:49 +0000
Subject: [PATCH] refactor(transformer/class-properties): rename
 `debug_assert_expr_is_not_parenthesis_or_typescript_syntax` (#7803)

Rename function to make it completely clear what it does.
---
 .../src/es2022/class_properties/private.rs          | 13 ++++++++-----
 .../src/es2022/class_properties/utils.rs            |  5 ++++-
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/crates/oxc_transformer/src/es2022/class_properties/private.rs b/crates/oxc_transformer/src/es2022/class_properties/private.rs
index 0dbfae74f62d0..bd84eb76b13fb 100644
--- a/crates/oxc_transformer/src/es2022/class_properties/private.rs
+++ b/crates/oxc_transformer/src/es2022/class_properties/private.rs
@@ -16,8 +16,8 @@ use crate::{common::helper_loader::Helper, TransformCtx};
 use super::{
     private_props::ResolvedPrivateProp,
     utils::{
-        assert_expr_neither_parenthesis_nor_typescript_syntax, create_assignment,
-        create_underscore_ident_name,
+        create_assignment, create_underscore_ident_name,
+        debug_assert_expr_is_not_parenthesis_or_typescript_syntax,
     },
     ClassProperties,
 };
@@ -1019,7 +1019,10 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
                 self.transform_call_expression_of_chain_expression(call, ctx)
             }
             _ => {
-                assert_expr_neither_parenthesis_nor_typescript_syntax(expr, &self.ctx.source_path);
+                debug_assert_expr_is_not_parenthesis_or_typescript_syntax(
+                    expr,
+                    &self.ctx.source_path,
+                );
                 None
             }
         }
@@ -1611,7 +1614,7 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
         object: Expression<'a>,
         ctx: &mut TraverseCtx<'a>,
     ) -> (Expression<'a>, Expression<'a>) {
-        assert_expr_neither_parenthesis_nor_typescript_syntax(&object, &self.ctx.source_path);
+        debug_assert_expr_is_not_parenthesis_or_typescript_syntax(&object, &self.ctx.source_path);
         self.ctx.duplicate_expression(object, false, ctx)
     }
 
@@ -1630,7 +1633,7 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
         object: Expression<'a>,
         ctx: &mut TraverseCtx<'a>,
     ) -> (Expression<'a>, Expression<'a>, Expression<'a>) {
-        assert_expr_neither_parenthesis_nor_typescript_syntax(&object, &self.ctx.source_path);
+        debug_assert_expr_is_not_parenthesis_or_typescript_syntax(&object, &self.ctx.source_path);
         self.ctx.duplicate_expression_twice(object, false, ctx)
     }
 
diff --git a/crates/oxc_transformer/src/es2022/class_properties/utils.rs b/crates/oxc_transformer/src/es2022/class_properties/utils.rs
index 082472d397ffd..be9c50d54220b 100644
--- a/crates/oxc_transformer/src/es2022/class_properties/utils.rs
+++ b/crates/oxc_transformer/src/es2022/class_properties/utils.rs
@@ -56,10 +56,13 @@ pub(super) fn create_underscore_ident_name<'a>(ctx: &mut TraverseCtx<'a>) -> Ide
     ctx.ast.identifier_name(SPAN, Atom::from("_"))
 }
 
+/// Debug assert that an `Expression` is not `ParenthesizedExpression` or TS syntax
+/// (e.g. `TSAsExpression`).
+//
 // `#[inline(always)]` because this is a no-op in release mode
 #[expect(clippy::inline_always)]
 #[inline(always)]
-pub(super) fn assert_expr_neither_parenthesis_nor_typescript_syntax(
+pub(super) fn debug_assert_expr_is_not_parenthesis_or_typescript_syntax(
     expr: &Expression,
     path: &PathBuf,
 ) {