Cannot open multiple vscode instances

[13hannes11]

Once vscode is opened by code . I cannot open another instance of it:

toolbox-vscode: Creating /root/.vscode-server/data/Machine/settings.json
/var/home/someuser/.local/bin/code: line 382: /root/.vscode-server/data/Machine/settings.json: Permission denied

[dyskette]

I'm using Fedora Silverblue with Flatpak 1.12.5 and I don't get that error. But trying to open another instance using code . again from toolbox doesn't work. It does nothing and doesn't output anything bad even with verbose arguments passed.

$ code --toolbox-verbose --verbose .
toolbox-vscode: Checking if Visual Studio Code Flatpak is installed
toolbox-vscode: Visual Studio Code Flatpak is installed
toolbox-vscode: Checking for running Visual Studio Code Flatpak
toolbox-vscode: Found running Visual Studio Code Flatpak, will use 'flatpak enter'
+ flatpak-spawn --host flatpak enter 2806685128 sh -c '
        cd $0
        HOME=$1
        shift
        DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/$UID/bus
        DBUS_SYSTEM_BUS_ADDRESS=unix:path=/run/dbus/system_bus_socket
        XDG_DATA_HOME="$HOME/.var/app/com.visualstudio.code/data"
        XDG_CONFIG_HOME="$HOME/.var/app/com.visualstudio.code/config"
        XDG_CACHE_HOME="$HOME/.var/app/com.visualstudio.code/cache"
        export HOME DBUS_SESSION_BUS_ADDRESS DBUS_SYSTEM_BUS_ADDRESS \
            XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME
        ELECTRON_RUN_AS_NODE=1 \
        PATH="${PATH}:$XDG_CONFIG_HOME/node_modules/bin" \
            exec "$@"
    ' /var/home/dyskette/Projects/storefront-themes /var/home/dyskette /app/extra/vscode/code /app/extra/vscode/resources/app/out/cli.js --extensions-dir=/var/home/dyskette/.var/app/com.visualstudio.code/data/vscode/extensions --remote attached-container+687870 --verbose /var/home/dyskette/Projects/storefront-themes

That's all the output. It just does nothing after that.

I removed the whole condition and left the flatpak run call only. That seemed to work for me.

[13hannes11]

I don't use that workflow anymore so sadly cannot verify if that would work for me.

[owtaylor]

Thanks for the report - turned out a small adjustment was needed in the code that opens another window in the existing process.

According to flathub/com.visualstudio.code#210 (comment) for Flatpak 1.11 and newer, we could simply remove all this complexity. After Fedora 34 EOL this spring (Flatpak 1.10), next time things break, I'll test and if it works, do go ahead and do that.

[dyskette]

Thanks. The change seems to works fine as well.