Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone and ISO localtime at published location in Recorder API #108

Closed
jpmens opened this issue Feb 3, 2024 · 4 comments
Closed

Timezone and ISO localtime at published location in Recorder API #108

jpmens opened this issue Feb 3, 2024 · 4 comments
Labels
Priority: High Do it soon Status: Done Feature has been implemented, bug fixed, question answered etc. Type: Feature New feature

Comments

@jpmens
Copy link
Member

jpmens commented Feb 3, 2024

The Recorder API now provides tzname and isolocal via the API.

  • tzname is the name of the time zone ($TZ) at the published location, e.g. Europe/Amsterdam
  • isolocal is the display-capable local time at the published location

I’m not sure what Frontend should do with this data, but I wanted to make sure you’re aware of this. :-)

@jpmens jpmens added the Type: Feature New feature label Feb 3, 2024
@linusg
Copy link
Member

linusg commented Feb 26, 2024

Happy to just add this to the popup, but it might need a new layout if it gets too crowded 😄
Gonna update my recorder to ensure I have this data and look into exposing it later today.

@linusg linusg added Priority: High Do it soon Status: In progress Someone's currently working on this labels Feb 26, 2024
@linusg linusg closed this as completed in 06faa73 Feb 26, 2024
@linusg
Copy link
Member

linusg commented Feb 26, 2024

A bit of a lazy solution, but I chose to glue both values together to form a valid ISO 8601 string that has both an offset and the time zone name:

image

Definitely can be improved by someone with UI skills, but it does show the data now :)

@linusg linusg added Status: Done Feature has been implemented, bug fixed, question answered etc. and removed Status: In progress Someone's currently working on this labels Feb 26, 2024
@linusg
Copy link
Member

linusg commented Feb 26, 2024

And a screenshot for matching viewer and device time zones:

image

@jpmens
Copy link
Member Author

jpmens commented Feb 27, 2024

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Do it soon Status: Done Feature has been implemented, bug fixed, question answered etc. Type: Feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants