mpc enable/disable toggles outputs instead of enable/disable them

[oliver-koch]

Problem Description

Enable/Disable a speakerr via mpc client toggles outputs instead of enable/disable them.
Affected Version: 28.11

root@host ~ # mpc --host 192.168.0.20 outputs
Output 1 (Speaker_01) is disabled
...
root@host ~ # mpc --host 192.168.0.20 disable 1
Output 1 (Speaker_01) is enabled
...
root@host ~ # mpc --host 192.168.0.20 disable 1
Output 1 (Speaker_01) is disabled
...
root@host ~ # mpc --host 192.168.0.20 enable 1
Output 1 (Speaker_01) is enabled
...
root@host ~ # mpc --host 192.168.0.20 enable 1
Output 1 (Speaker_01) is disabled
...

Expected Behaviour

mpc enable1 → Enables output if disabled, if already enabled do nothing.
mpc disable 1 → Disable output if enabled, if already disabled do nothing.

[ejurgensen]

Thanks for reporting, sounds like a clear bug. There was also a speaker selection bug in version 28.10, and it could sound like my fix for it wasn't quite good.

[oliver-koch]

Yes, the previous one was also reported by me. 😄
With 28.9 it works as expected.

Thanks for your great work!

[ejurgensen]

Added a fix, thanks for reporting!