From 6b6254011b42480a16c77913e11ac36a17f451e7 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 6 Feb 2023 15:07:45 +0100
Subject: [PATCH 01/15] Add batch actions for spaces list

---
 .../src/views/Spaces.vue                      | 29 +++++++++++++++++--
 .../web-pkg/src/mixins/spaces/editQuota.ts    |  6 +---
 2 files changed, 27 insertions(+), 8 deletions(-)

diff --git a/packages/web-app-admin-settings/src/views/Spaces.vue b/packages/web-app-admin-settings/src/views/Spaces.vue
index 23c6ebee1a4..38e56cead24 100644
--- a/packages/web-app-admin-settings/src/views/Spaces.vue
+++ b/packages/web-app-admin-settings/src/views/Spaces.vue
@@ -38,6 +38,12 @@
         </div>
       </template>
       <template #mainContent>
+        <quota-modal
+          v-if="quotaModalIsOpen"
+          :cancel="closeQuotaModal"
+          :space="quotaModalSelectedSpace"
+          @space-quota-updated="spaceQuotaUpdated"
+        />
         <no-content-message
           v-if="!spaces.length"
           id="admin-settings-spaces-empty"
@@ -97,6 +103,8 @@ import ActionsPanel from '../components/Spaces/SideBar/ActionsPanel.vue'
 import Delete from 'web-pkg/src/mixins/spaces/delete'
 import Disable from 'web-pkg/src/mixins/spaces/disable'
 import Restore from 'web-pkg/src/mixins/spaces/restore'
+import EditQuota from 'web-pkg/src/mixins/spaces/editQuota'
+import QuotaModal from 'web-pkg/src/components/Spaces/QuotaModal.vue'
 import { useSideBar } from 'web-pkg/src/composables/sideBar'
 import { useGettext } from 'vue3-gettext'
 
@@ -108,9 +116,10 @@ export default defineComponent({
     NoContentMessage,
     ContextActions,
     SpaceInfo,
-    BatchActions
+    BatchActions, 
+    QuotaModal
   },
-  mixins: [Delete, Disable, Restore],
+  mixins: [Delete, Disable, Restore, EditQuota],
   provide() {
     return {
       resource: computed(() => this.selectedSpaces[0])
@@ -176,6 +185,7 @@ export default defineComponent({
 
     const batchActions = computed(() => {
       return [
+        ...instance.$_editQuota_items,
         ...instance.$_restore_items,
         ...instance.$_delete_items,
         ...instance.$_disable_items
@@ -260,6 +270,15 @@ export default defineComponent({
       resizeObserver.unobserve(unref(appBarActionsRef))
     })
 
+    const quotaModalSelectedSpace = computed(() => instance.$data.$_editQuota_selectedSpace)
+    const quotaModalIsOpen = computed(() => instance.$data.$_editQuota_modalOpen)
+    const closeQuotaModal = () => {
+      instance.$_editQuota_closeModal()
+    }
+    const spaceQuotaUpdated = (quota) => {
+      instance.$data.$_editQuota_selectedSpace.spaceQuota = quota
+    }
+
     return {
       sideBarOpen,
       sideBarActivePanel,
@@ -278,7 +297,11 @@ export default defineComponent({
       unselectAllSpaces,
       limitedScreenSpace,
       appBarActionsRef,
-      onResize
+      onResize,
+      quotaModalSelectedSpace,
+      quotaModalIsOpen,
+      closeQuotaModal,
+      spaceQuotaUpdated
     }
   }
 })
diff --git a/packages/web-pkg/src/mixins/spaces/editQuota.ts b/packages/web-pkg/src/mixins/spaces/editQuota.ts
index 65866a743b8..4c88eeb410e 100644
--- a/packages/web-pkg/src/mixins/spaces/editQuota.ts
+++ b/packages/web-pkg/src/mixins/spaces/editQuota.ts
@@ -21,11 +21,7 @@ export default {
           },
           handler: this.$_editQuota_trigger,
           isEnabled: ({ resources }) => {
-            if (resources.length !== 1) {
-              return false
-            }
-
-            if (!resources[0].spaceQuota) {
+            if (resources.some(r => r.spaceQuota === false)) {
               return false
             }
 

From 92d5baf9cdbccb4c9c9d00fd67525da48db21b02 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Tue, 7 Feb 2023 12:14:27 +0100
Subject: [PATCH 02/15] Refactor QuotaModal, Implement batch quota edit admin

---
 .../src/components/Spaces/ContextActions.vue  |  5 +-
 .../Spaces/SideBar/ActionsPanel.vue           |  2 +-
 .../src/views/Spaces.vue                      |  6 +-
 .../SideBar/Actions/SpaceActions.vue          |  2 +-
 .../components/Spaces/SpaceContextActions.vue |  4 +-
 .../src/components/Spaces/QuotaModal.vue      | 76 +++++++++++--------
 .../web-pkg/src/mixins/spaces/editQuota.ts    |  2 +-
 7 files changed, 52 insertions(+), 45 deletions(-)

diff --git a/packages/web-app-admin-settings/src/components/Spaces/ContextActions.vue b/packages/web-app-admin-settings/src/components/Spaces/ContextActions.vue
index 80609fea8db..46a41919187 100644
--- a/packages/web-app-admin-settings/src/components/Spaces/ContextActions.vue
+++ b/packages/web-app-admin-settings/src/components/Spaces/ContextActions.vue
@@ -4,7 +4,7 @@
     <quota-modal
       v-if="quotaModalIsOpen"
       :cancel="closeQuotaModal"
-      :space="quotaModalSelectedSpace"
+      :spaces="items"
       @space-quota-updated="spaceQuotaUpdated"
     />
   </div>
@@ -77,8 +77,6 @@ export default defineComponent({
       }
       return sections
     })
-
-    const quotaModalSelectedSpace = computed(() => instance.$data.$_editQuota_selectedSpace)
     const quotaModalIsOpen = computed(() => instance.$data.$_editQuota_modalOpen)
     const closeQuotaModal = () => {
       instance.$_editQuota_closeModal()
@@ -88,7 +86,6 @@ export default defineComponent({
     }
     return {
       menuSections,
-      quotaModalSelectedSpace,
       quotaModalIsOpen,
       closeQuotaModal,
       spaceQuotaUpdated
diff --git a/packages/web-app-admin-settings/src/components/Spaces/SideBar/ActionsPanel.vue b/packages/web-app-admin-settings/src/components/Spaces/SideBar/ActionsPanel.vue
index 0f35b1a9c47..231af29a132 100644
--- a/packages/web-app-admin-settings/src/components/Spaces/SideBar/ActionsPanel.vue
+++ b/packages/web-app-admin-settings/src/components/Spaces/SideBar/ActionsPanel.vue
@@ -3,7 +3,7 @@
     <quota-modal
       v-if="quotaModalIsOpen"
       :cancel="closeQuotaModal"
-      :space="resources[0]"
+      :spaces="[resources[0]]"
       @space-quota-updated="spaceQuotaUpdated"
     />
     <oc-list id="oc-spaces-actions-sidebar" class-name="oc-mt-s">
diff --git a/packages/web-app-admin-settings/src/views/Spaces.vue b/packages/web-app-admin-settings/src/views/Spaces.vue
index 38e56cead24..39059a4276d 100644
--- a/packages/web-app-admin-settings/src/views/Spaces.vue
+++ b/packages/web-app-admin-settings/src/views/Spaces.vue
@@ -41,7 +41,7 @@
         <quota-modal
           v-if="quotaModalIsOpen"
           :cancel="closeQuotaModal"
-          :space="quotaModalSelectedSpace"
+          :spaces="selectedSpaces"
           @space-quota-updated="spaceQuotaUpdated"
         />
         <no-content-message
@@ -116,7 +116,7 @@ export default defineComponent({
     NoContentMessage,
     ContextActions,
     SpaceInfo,
-    BatchActions, 
+    BatchActions,
     QuotaModal
   },
   mixins: [Delete, Disable, Restore, EditQuota],
@@ -270,7 +270,6 @@ export default defineComponent({
       resizeObserver.unobserve(unref(appBarActionsRef))
     })
 
-    const quotaModalSelectedSpace = computed(() => instance.$data.$_editQuota_selectedSpace)
     const quotaModalIsOpen = computed(() => instance.$data.$_editQuota_modalOpen)
     const closeQuotaModal = () => {
       instance.$_editQuota_closeModal()
@@ -298,7 +297,6 @@ export default defineComponent({
       limitedScreenSpace,
       appBarActionsRef,
       onResize,
-      quotaModalSelectedSpace,
       quotaModalIsOpen,
       closeQuotaModal,
       spaceQuotaUpdated
diff --git a/packages/web-app-files/src/components/SideBar/Actions/SpaceActions.vue b/packages/web-app-files/src/components/SideBar/Actions/SpaceActions.vue
index 14a5fa5ea9a..f5ba5036b3f 100644
--- a/packages/web-app-files/src/components/SideBar/Actions/SpaceActions.vue
+++ b/packages/web-app-files/src/components/SideBar/Actions/SpaceActions.vue
@@ -5,7 +5,7 @@
       :cancel="closeReadmeContentModal"
       :space="resources[0]"
     ></readme-content-modal>
-    <quota-modal v-if="quotaModalIsOpen" :cancel="closeQuotaModal" :space="resources[0]" />
+    <quota-modal v-if="quotaModalIsOpen" :cancel="closeQuotaModal" :spaces="[resources[0]]" />
     <input
       id="space-image-upload-input"
       ref="spaceImageInput"
diff --git a/packages/web-app-files/src/components/Spaces/SpaceContextActions.vue b/packages/web-app-files/src/components/Spaces/SpaceContextActions.vue
index e957e8f5bf3..258e1d278e9 100644
--- a/packages/web-app-files/src/components/Spaces/SpaceContextActions.vue
+++ b/packages/web-app-files/src/components/Spaces/SpaceContextActions.vue
@@ -4,7 +4,7 @@
     <quota-modal
       v-if="quotaModalIsOpen"
       :cancel="closeQuotaModal"
-      :space="quotaModalSelectedSpace"
+      :spaces="quotaModalSelectedSpace"
     />
     <readme-content-modal
       v-if="readmeContentModalIsOpen"
@@ -75,7 +75,7 @@ export default defineComponent({
 
   computed: {
     quotaModalSelectedSpace() {
-      return this.$data.$_editQuota_selectedSpace
+      return [this.$data.$_editQuota_selectedSpace]
     },
     quotaModalIsOpen() {
       return this.$data.$_editQuota_modalOpen
diff --git a/packages/web-pkg/src/components/Spaces/QuotaModal.vue b/packages/web-pkg/src/components/Spaces/QuotaModal.vue
index adc51279874..70b20236ddb 100644
--- a/packages/web-pkg/src/components/Spaces/QuotaModal.vue
+++ b/packages/web-pkg/src/components/Spaces/QuotaModal.vue
@@ -31,8 +31,8 @@ export default defineComponent({
     QuotaSelect
   },
   props: {
-    space: {
-      type: Object,
+    spaces: {
+      type: Array,
       required: true
     },
     cancel: {
@@ -53,16 +53,23 @@ export default defineComponent({
   },
   computed: {
     confirmButtonDisabled() {
-      return this.space.spaceQuota.total === this.selectedOption
+      return !this.spaces.some((space) => space.spaceQuota.total !== this.selectedOption)
     },
     modalTitle() {
-      return this.$gettextInterpolate(this.$gettext('Change quota for space %{name}'), {
-        name: this.space.name
+      if (this.spaces.length === 1) {
+        return this.$gettext('Change quota for space %{name}', {
+          name: this.spaces[0].name
+        })
+      }
+      return this.$gettext('Change quota for %{count} spaces', {
+        count: this.spaces.length
       })
     }
   },
   mounted() {
-    this.selectedOption = this.space.spaceQuota.total || 0
+    console.log('==!!==')
+    console.log(this.spaces)
+    this.selectedOption = this.spaces[0].spaceQuota.total || 0
   },
   methods: {
     ...mapActions(['showMessage']),
@@ -73,34 +80,39 @@ export default defineComponent({
       this.selectedOption = option.value
     },
     editQuota() {
-      return this.graphClient.drives
-        .updateDrive(this.space.id, { quota: { total: this.selectedOption } }, {})
-        .then(({ data }) => {
-          this.cancel()
-          if (unref(this.$router.currentRoute).name === 'admin-settings-spaces') {
-            this.$emit('spaceQuotaUpdated', data.quota)
-          }
-          this.UPDATE_SPACE_FIELD({
-            id: this.space.id,
-            field: 'spaceQuota',
-            value: data.quota
-          })
-          this.UPDATE_RESOURCE_FIELD({
-            id: this.space.id,
-            field: 'spaceQuota',
-            value: data.quota
-          })
-          this.showMessage({
-            title: this.$gettext('Space quota was changed successfully')
+      const requests = []
+      this.spaces.forEach((space) => {
+        const request = this.graphClient.drives
+          .updateDrive(space.id, { quota: { total: this.selectedOption } }, {})
+          .then(({ data }) => {
+            this.cancel()
+            if (unref(this.$router.currentRoute).name === 'admin-settings-spaces') {
+              this.$emit('spaceQuotaUpdated', data.quota)
+            }
+            this.UPDATE_SPACE_FIELD({
+              id: space.id,
+              field: 'spaceQuota',
+              value: data.quota
+            })
+            this.UPDATE_RESOURCE_FIELD({
+              id: space.id,
+              field: 'spaceQuota',
+              value: data.quota
+            })
+            this.showMessage({
+              title: this.$gettext('Space quota was changed successfully')
+            })
           })
-        })
-        .catch((error) => {
-          console.error(error)
-          this.showMessage({
-            title: this.$gettext('Failed to change space quota'),
-            status: 'danger'
+          .catch((error) => {
+            console.error(error)
+            this.showMessage({
+              title: this.$gettext('Failed to change space quota'),
+              status: 'danger'
+            })
           })
-        })
+        requests.push(request)
+      })
+      return Promise.all(requests)
     }
   }
 })
diff --git a/packages/web-pkg/src/mixins/spaces/editQuota.ts b/packages/web-pkg/src/mixins/spaces/editQuota.ts
index 4c88eeb410e..29121d77cda 100644
--- a/packages/web-pkg/src/mixins/spaces/editQuota.ts
+++ b/packages/web-pkg/src/mixins/spaces/editQuota.ts
@@ -21,7 +21,7 @@ export default {
           },
           handler: this.$_editQuota_trigger,
           isEnabled: ({ resources }) => {
-            if (resources.some(r => r.spaceQuota === false)) {
+            if (resources.some((r) => r.spaceQuota === false)) {
               return false
             }
 

From d034690c8eceb0460aa826735f796c40cf0a1fc5 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Wed, 8 Feb 2023 15:05:40 +0100
Subject: [PATCH 03/15] Add quota edit to userlist

---
 .../src/components/Users/ContextActions.vue   | 37 +++++++++++++++++--
 1 file changed, 34 insertions(+), 3 deletions(-)

diff --git a/packages/web-app-admin-settings/src/components/Users/ContextActions.vue b/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
index 1ac640f42e6..74c6201f184 100644
--- a/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
+++ b/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
@@ -1,6 +1,12 @@
 <template>
   <div>
     <context-action-menu :menu-sections="menuSections" :items="items" />
+    <quota-modal
+      v-if="quotaModalIsOpen"
+      :cancel="closeQuotaModal"
+      :spaces="drives"
+      @space-quota-updated="spaceQuotaUpdated"
+    />
   </div>
 </template>
 
@@ -11,17 +17,24 @@ import Edit from '../../mixins/users/edit'
 import { computed, defineComponent, getCurrentInstance, PropType, unref } from 'vue'
 import ContextActionMenu from 'web-pkg/src/components/ContextActions/ContextActionMenu.vue'
 import { User } from 'web-client/src/generated'
+import QuotaModal from 'web-pkg/src/components/Spaces/QuotaModal.vue'
+import EditQuota from 'web-pkg/src/mixins/spaces/editQuota'
 
 export default defineComponent({
   name: 'ContextActions',
-  components: { ContextActionMenu },
-  mixins: [Delete, Edit, ShowDetails],
+  components: { ContextActionMenu, QuotaModal },
+  mixins: [Delete, Edit, ShowDetails, EditQuota],
   props: {
     items: {
       type: Array as PropType<User[]>,
       required: true
     }
   },
+  watch: {
+    items() {
+      console.log(1337, this.items)
+    }
+  },
   setup(props) {
     const instance = getCurrentInstance().proxy as any
 
@@ -54,8 +67,26 @@ export default defineComponent({
       return sections
     })
 
+    const quotaModalIsOpen = computed(() => instance.$data.$_editQuota_modalOpen)
+    const closeQuotaModal = () => {
+      instance.$_editQuota_closeModal()
+    }
+    const spaceQuotaUpdated = (quota) => {
+      instance.$data.$_editQuota_selectedSpace.spaceQuota = quota
+    }
+
+    const drives = () => {
+      const list = []
+      props.items.forEach(u => list.push(u.drive))
+      return list
+    }
+
     return {
-      menuSections
+      menuSections,
+      quotaModalIsOpen,
+      closeQuotaModal,
+      spaceQuotaUpdated,
+      drives
     }
   }
 })

From 2780e8259b60e36fd2ff7ed140a5b61d81eab898 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Thu, 9 Feb 2023 11:11:42 +0100
Subject: [PATCH 04/15] Make user list load drive on select

---
 .../src/views/Users.vue                       | 33 ++++++++++---------
 1 file changed, 18 insertions(+), 15 deletions(-)

diff --git a/packages/web-app-admin-settings/src/views/Users.vue b/packages/web-app-admin-settings/src/views/Users.vue
index 9849eff63c0..762c57aa061 100644
--- a/packages/web-app-admin-settings/src/views/Users.vue
+++ b/packages/web-app-admin-settings/src/views/Users.vue
@@ -182,6 +182,7 @@ export default defineComponent({
      */
     const loadAdditionalUserDataTask = useTask(function* (signal, user) {
       const { data } = yield unref(graphClient).users.getUser(user.id)
+      console.log("Hi im called", data)
       return data
     })
 
@@ -190,26 +191,28 @@ export default defineComponent({
       loadUsersTask.perform(groupIds)
     }
 
+    
     watch(
-      selectedUsers,
+      () => unref(selectedUsers).length,
       async () => {
-        const loadAdditionalData = unref(selectedUsers).length === 1
-        if (loadAdditionalData && unref(loadedUser)?.id === unref(selectedUsers)[0].id) {
-          // current user is already loaded
-          return
-        }
-
         sideBarLoading.value = true
-        if (loadAdditionalData) {
-          loadedUser.value = await loadAdditionalUserDataTask.perform(unref(selectedUsers)[0])
-          sideBarLoading.value = false
-          return
-        }
+        const requests = []
+        unref(selectedUsers).forEach((user) => {
+          requests.push(loadAdditionalUserDataTask.perform(user))
+        })
 
-        loadedUser.value = null
+        const loadedUsers = await Promise.all(requests)
+        unref(selectedUsers).forEach((user) => {
+          const additionalUserData = loadedUsers.find((loadedUser) => loadedUser.id === user.id)
+          Object.assign(user, additionalUserData)
+          if(unref(selectedUsers).length === 1) {
+            loadedUser.value = additionalUserData
+            return
+          }
+          loadedUser.value = null
+        })
         sideBarLoading.value = false
-      },
-      { deep: true }
+      }
     )
 
     const calculateListHeaderPosition = () => {

From b0684848991b4f8fc70647e209436aaba88e9f9c Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Fri, 10 Feb 2023 15:32:36 +0100
Subject: [PATCH 05/15] Implement batch quota modal for context actions

---
 .../src/components/Users/ContextActions.vue   | 44 +++++++++++++------
 .../src/views/Users.vue                       |  4 +-
 .../src/components/Spaces/QuotaModal.vue      |  1 -
 .../web-pkg/src/mixins/spaces/editQuota.ts    |  1 -
 4 files changed, 32 insertions(+), 18 deletions(-)

diff --git a/packages/web-app-admin-settings/src/components/Users/ContextActions.vue b/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
index 74c6201f184..38b93ee916b 100644
--- a/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
+++ b/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
@@ -4,7 +4,7 @@
     <quota-modal
       v-if="quotaModalIsOpen"
       :cancel="closeQuotaModal"
-      :spaces="drives"
+      :spaces="selectedPersonalDrives"
       @space-quota-updated="spaceQuotaUpdated"
     />
   </div>
@@ -19,6 +19,9 @@ import ContextActionMenu from 'web-pkg/src/components/ContextActions/ContextActi
 import { User } from 'web-client/src/generated'
 import QuotaModal from 'web-pkg/src/components/Spaces/QuotaModal.vue'
 import EditQuota from 'web-pkg/src/mixins/spaces/editQuota'
+import { watch, toRaw } from 'vue'
+import { SpaceResource } from 'web-client/src'
+import { reactive } from 'vue'
 
 export default defineComponent({
   name: 'ContextActions',
@@ -30,20 +33,35 @@ export default defineComponent({
       required: true
     }
   },
-  watch: {
-    items() {
-      console.log(1337, this.items)
-    }
-  },
   setup(props) {
     const instance = getCurrentInstance().proxy as any
 
     const filterParams = computed(() => ({ resources: props.items }))
+    const selectedPersonalDrives = reactive([])
+    watch(
+      () => props.items,
+      async () => {
+        selectedPersonalDrives.splice(0, selectedPersonalDrives.length)
+        props.items.forEach((user) => {
+          const drive = toRaw(user.drive)
+          const spaceResource = {
+            id: drive.id,
+            name: 'Personal Drive of ' + user.displayName,
+            spaceQuota: drive.quota
+          } as SpaceResource
+          selectedPersonalDrives.push(spaceResource)
+        })
+      },
+      { deep: true, immediate: true }
+    )
     const menuItemsPrimaryActions = computed(() =>
       [...instance.$_edit_items, ...instance.$_delete_items].filter((item) =>
         item.isEnabled(unref(filterParams))
       )
     )
+    const menuItemsSecondaryActions = computed(() =>
+      [...instance.$_editQuota_items].filter((item) => item.isEnabled(unref(filterParams)))
+    )
 
     const menuItemsSidebar = computed(() =>
       [...instance.$_showDetails_items].filter((item) => item.isEnabled(unref(filterParams)))
@@ -58,6 +76,12 @@ export default defineComponent({
           items: unref(menuItemsPrimaryActions)
         })
       }
+      if (unref(menuItemsSecondaryActions).length) {
+        sections.push({
+          name: 'secondaryActions',
+          items: unref(menuItemsSecondaryActions)
+        })
+      }
       if (unref(menuItemsSidebar).length) {
         sections.push({
           name: 'sidebar',
@@ -75,18 +99,12 @@ export default defineComponent({
       instance.$data.$_editQuota_selectedSpace.spaceQuota = quota
     }
 
-    const drives = () => {
-      const list = []
-      props.items.forEach(u => list.push(u.drive))
-      return list
-    }
-
     return {
       menuSections,
       quotaModalIsOpen,
       closeQuotaModal,
       spaceQuotaUpdated,
-      drives
+      selectedPersonalDrives
     }
   }
 })
diff --git a/packages/web-app-admin-settings/src/views/Users.vue b/packages/web-app-admin-settings/src/views/Users.vue
index 762c57aa061..de48c7fc5a7 100644
--- a/packages/web-app-admin-settings/src/views/Users.vue
+++ b/packages/web-app-admin-settings/src/views/Users.vue
@@ -182,7 +182,6 @@ export default defineComponent({
      */
     const loadAdditionalUserDataTask = useTask(function* (signal, user) {
       const { data } = yield unref(graphClient).users.getUser(user.id)
-      console.log("Hi im called", data)
       return data
     })
 
@@ -191,7 +190,6 @@ export default defineComponent({
       loadUsersTask.perform(groupIds)
     }
 
-    
     watch(
       () => unref(selectedUsers).length,
       async () => {
@@ -205,7 +203,7 @@ export default defineComponent({
         unref(selectedUsers).forEach((user) => {
           const additionalUserData = loadedUsers.find((loadedUser) => loadedUser.id === user.id)
           Object.assign(user, additionalUserData)
-          if(unref(selectedUsers).length === 1) {
+          if (unref(selectedUsers).length === 1) {
             loadedUser.value = additionalUserData
             return
           }
diff --git a/packages/web-pkg/src/components/Spaces/QuotaModal.vue b/packages/web-pkg/src/components/Spaces/QuotaModal.vue
index 70b20236ddb..30fad665407 100644
--- a/packages/web-pkg/src/components/Spaces/QuotaModal.vue
+++ b/packages/web-pkg/src/components/Spaces/QuotaModal.vue
@@ -67,7 +67,6 @@ export default defineComponent({
     }
   },
   mounted() {
-    console.log('==!!==')
     console.log(this.spaces)
     this.selectedOption = this.spaces[0].spaceQuota.total || 0
   },
diff --git a/packages/web-pkg/src/mixins/spaces/editQuota.ts b/packages/web-pkg/src/mixins/spaces/editQuota.ts
index 29121d77cda..bef4025dc92 100644
--- a/packages/web-pkg/src/mixins/spaces/editQuota.ts
+++ b/packages/web-pkg/src/mixins/spaces/editQuota.ts
@@ -24,7 +24,6 @@ export default {
             if (resources.some((r) => r.spaceQuota === false)) {
               return false
             }
-
             return this.$permissionManager.canEditSpaceQuota()
           },
           componentType: 'button',

From 5f2129d80f6a6d5afa4e60184c12041327973d37 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Fri, 10 Feb 2023 15:42:52 +0100
Subject: [PATCH 06/15] Fix some small bug

---
 .../src/components/Users/ContextActions.vue                | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/packages/web-app-admin-settings/src/components/Users/ContextActions.vue b/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
index 38b93ee916b..b499be00ac5 100644
--- a/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
+++ b/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
@@ -35,7 +35,7 @@ export default defineComponent({
   },
   setup(props) {
     const instance = getCurrentInstance().proxy as any
-
+    const $gettext = instance.$gettext
     const filterParams = computed(() => ({ resources: props.items }))
     const selectedPersonalDrives = reactive([])
     watch(
@@ -44,9 +44,12 @@ export default defineComponent({
         selectedPersonalDrives.splice(0, selectedPersonalDrives.length)
         props.items.forEach((user) => {
           const drive = toRaw(user.drive)
+          if(drive === undefined || drive.id === undefined) {
+            return;
+          }
           const spaceResource = {
             id: drive.id,
-            name: 'Personal Drive of ' + user.displayName,
+            name: $gettext(' of %{name}', { name: user.displayName}),
             spaceQuota: drive.quota
           } as SpaceResource
           selectedPersonalDrives.push(spaceResource)

From 9defd8e75e91cf25cde448f52e731efec84204fa Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 13 Feb 2023 09:27:59 +0100
Subject: [PATCH 07/15] Add quota modal to users batch actions

---
 .../src/components/Users/ContextActions.vue   |  6 +--
 .../src/views/Users.vue                       | 42 +++++++++++++++++--
 2 files changed, 42 insertions(+), 6 deletions(-)

diff --git a/packages/web-app-admin-settings/src/components/Users/ContextActions.vue b/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
index b499be00ac5..0b40d440130 100644
--- a/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
+++ b/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
@@ -44,12 +44,12 @@ export default defineComponent({
         selectedPersonalDrives.splice(0, selectedPersonalDrives.length)
         props.items.forEach((user) => {
           const drive = toRaw(user.drive)
-          if(drive === undefined || drive.id === undefined) {
-            return;
+          if (drive === undefined || drive.id === undefined) {
+            return
           }
           const spaceResource = {
             id: drive.id,
-            name: $gettext(' of %{name}', { name: user.displayName}),
+            name: $gettext(' of %{name}', { name: user.displayName }),
             spaceQuota: drive.quota
           } as SpaceResource
           selectedPersonalDrives.push(spaceResource)
diff --git a/packages/web-app-admin-settings/src/views/Users.vue b/packages/web-app-admin-settings/src/views/Users.vue
index de48c7fc5a7..1d0950a3aad 100644
--- a/packages/web-app-admin-settings/src/views/Users.vue
+++ b/packages/web-app-admin-settings/src/views/Users.vue
@@ -83,6 +83,12 @@
       @cancel="toggleCreateUserModal"
       @confirm="createUser"
     />
+    <quota-modal
+      v-if="quotaModalIsOpen"
+      :cancel="closeQuotaModal"
+      :spaces="selectedPersonalDrives"
+      @space-quota-updated="spaceQuotaUpdated"
+    />
   </div>
 </template>
 
@@ -120,6 +126,9 @@ import AppTemplate from '../components/AppTemplate.vue'
 import { useSideBar } from 'web-pkg/src/composables/sideBar'
 import ItemFilter from 'web-pkg/src/components/ItemFilter.vue'
 import AppLoadingSpinner from 'web-pkg/src/components/AppLoadingSpinner.vue'
+import EditQuota from 'web-pkg/src/mixins/spaces/editQuota'
+import { toRaw } from 'vue'
+import { SpaceResource } from 'web-client/src'
 
 export default defineComponent({
   name: 'UsersView',
@@ -132,9 +141,10 @@ export default defineComponent({
     ContextActions,
     ItemFilter
   },
-  mixins: [Delete],
+  mixins: [Delete, EditQuota],
   setup() {
     const instance = getCurrentInstance().proxy as any
+    const $gettext = instance.$gettext
     const store = useStore()
     const accessToken = useAccessToken({ store })
     const { graphClient } = useGraphClient()
@@ -190,6 +200,7 @@ export default defineComponent({
       loadUsersTask.perform(groupIds)
     }
 
+    const selectedPersonalDrives = ref([])
     watch(
       () => unref(selectedUsers).length,
       async () => {
@@ -210,6 +221,19 @@ export default defineComponent({
           loadedUser.value = null
         })
         sideBarLoading.value = false
+        selectedPersonalDrives.value.splice(0, unref(selectedPersonalDrives).length)
+        unref(selectedUsers).forEach((user) => {
+          const drive = toRaw(user.drive)
+          if (drive === undefined || drive.id === undefined) {
+            return
+          }
+          const spaceResource = {
+            id: drive.id,
+            name: $gettext(' of %{name}', { name: user.displayName }),
+            spaceQuota: drive.quota
+          } as SpaceResource
+          selectedPersonalDrives.value.push(spaceResource)
+        })
       }
     )
 
@@ -218,7 +242,7 @@ export default defineComponent({
     }
 
     const batchActions = computed(() => {
-      return [...instance.$_delete_items].filter((item) =>
+      return [...instance.$_delete_items, ...instance.$_editQuota_items].filter((item) =>
         item.isEnabled({ resources: unref(selectedUsers) })
       )
     })
@@ -246,6 +270,14 @@ export default defineComponent({
       eventBus.unsubscribe('app.admin-settings.users.user.updated', userUpdatedEventToken)
     })
 
+    const quotaModalIsOpen = computed(() => instance.$data.$_editQuota_modalOpen)
+    const closeQuotaModal = () => {
+      instance.$_editQuota_closeModal()
+    }
+    const spaceQuotaUpdated = (quota) => {
+      instance.$data.$_editQuota_selectedSpace.spaceQuota = quota
+    }
+
     return {
       ...useSideBar(),
       template,
@@ -262,7 +294,11 @@ export default defineComponent({
       listHeaderPosition,
       createUserModalOpen,
       batchActions,
-      filterGroups
+      filterGroups,
+      quotaModalIsOpen,
+      closeQuotaModal,
+      spaceQuotaUpdated,
+      selectedPersonalDrives
     }
   },
   computed: {

From 5733bcf15d43916a66cfa82ed3e7b77d5744d0ef Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 13 Feb 2023 09:40:01 +0100
Subject: [PATCH 08/15] Add changelog

---
 .../enhancement-admin-change-spaces-quota-batch-action      | 6 ++++++
 packages/web-app-admin-settings/src/views/Users.vue         | 1 +
 packages/web-pkg/src/components/Spaces/QuotaModal.vue       | 1 -
 3 files changed, 7 insertions(+), 1 deletion(-)
 create mode 100644 changelog/unreleased/enhancement-admin-change-spaces-quota-batch-action

diff --git a/changelog/unreleased/enhancement-admin-change-spaces-quota-batch-action b/changelog/unreleased/enhancement-admin-change-spaces-quota-batch-action
new file mode 100644
index 00000000000..0ae3da11125
--- /dev/null
+++ b/changelog/unreleased/enhancement-admin-change-spaces-quota-batch-action
@@ -0,0 +1,6 @@
+Enhancement: Batch edit quota in admin panel
+
+We've added the batch edit quota functionality to the admin panel for users personal space and in the spaces list
+
+https://github.com/owncloud/web/pull/8387
+https://github.com/owncloud/web/issues/8417
\ No newline at end of file
diff --git a/packages/web-app-admin-settings/src/views/Users.vue b/packages/web-app-admin-settings/src/views/Users.vue
index 1d0950a3aad..0a3e7b70c2e 100644
--- a/packages/web-app-admin-settings/src/views/Users.vue
+++ b/packages/web-app-admin-settings/src/views/Users.vue
@@ -205,6 +205,7 @@ export default defineComponent({
       () => unref(selectedUsers).length,
       async () => {
         sideBarLoading.value = true
+        // Load additional user data
         const requests = []
         unref(selectedUsers).forEach((user) => {
           requests.push(loadAdditionalUserDataTask.perform(user))
diff --git a/packages/web-pkg/src/components/Spaces/QuotaModal.vue b/packages/web-pkg/src/components/Spaces/QuotaModal.vue
index 30fad665407..1b3d287b650 100644
--- a/packages/web-pkg/src/components/Spaces/QuotaModal.vue
+++ b/packages/web-pkg/src/components/Spaces/QuotaModal.vue
@@ -67,7 +67,6 @@ export default defineComponent({
     }
   },
   mounted() {
-    console.log(this.spaces)
     this.selectedOption = this.spaces[0].spaceQuota.total || 0
   },
   methods: {

From b46da3c3eab5d86c3d1d62f4329e97b54bc03116 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 13 Feb 2023 12:59:00 +0100
Subject: [PATCH 09/15] Address some PR issues

---
 .../src/components/Users/ContextActions.vue   | 22 +++++++++++++------
 .../src/views/Users.vue                       |  8 +++++--
 .../src/components/Spaces/QuotaModal.vue      |  5 +++--
 3 files changed, 24 insertions(+), 11 deletions(-)

diff --git a/packages/web-app-admin-settings/src/components/Users/ContextActions.vue b/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
index 0b40d440130..799e6184117 100644
--- a/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
+++ b/packages/web-app-admin-settings/src/components/Users/ContextActions.vue
@@ -14,14 +14,22 @@
 import ShowDetails from '../../mixins/showDetails'
 import Delete from '../../mixins/users/delete'
 import Edit from '../../mixins/users/edit'
-import { computed, defineComponent, getCurrentInstance, PropType, unref } from 'vue'
+import {
+  computed,
+  defineComponent,
+  getCurrentInstance,
+  PropType,
+  unref,
+  watch,
+  toRaw,
+  ref
+} from 'vue'
 import ContextActionMenu from 'web-pkg/src/components/ContextActions/ContextActionMenu.vue'
 import { User } from 'web-client/src/generated'
 import QuotaModal from 'web-pkg/src/components/Spaces/QuotaModal.vue'
 import EditQuota from 'web-pkg/src/mixins/spaces/editQuota'
-import { watch, toRaw } from 'vue'
 import { SpaceResource } from 'web-client/src'
-import { reactive } from 'vue'
+import { useGettext } from 'vue3-gettext'
 
 export default defineComponent({
   name: 'ContextActions',
@@ -35,13 +43,13 @@ export default defineComponent({
   },
   setup(props) {
     const instance = getCurrentInstance().proxy as any
-    const $gettext = instance.$gettext
+    const { $gettext } = useGettext()
     const filterParams = computed(() => ({ resources: props.items }))
-    const selectedPersonalDrives = reactive([])
+    const selectedPersonalDrives = ref([])
     watch(
       () => props.items,
       async () => {
-        selectedPersonalDrives.splice(0, selectedPersonalDrives.length)
+        selectedPersonalDrives.value.splice(0, unref(selectedPersonalDrives).length)
         props.items.forEach((user) => {
           const drive = toRaw(user.drive)
           if (drive === undefined || drive.id === undefined) {
@@ -52,7 +60,7 @@ export default defineComponent({
             name: $gettext(' of %{name}', { name: user.displayName }),
             spaceQuota: drive.quota
           } as SpaceResource
-          selectedPersonalDrives.push(spaceResource)
+          selectedPersonalDrives.value.push(spaceResource)
         })
       },
       { deep: true, immediate: true }
diff --git a/packages/web-app-admin-settings/src/views/Users.vue b/packages/web-app-admin-settings/src/views/Users.vue
index 0a3e7b70c2e..4cc400f9ac2 100644
--- a/packages/web-app-admin-settings/src/views/Users.vue
+++ b/packages/web-app-admin-settings/src/views/Users.vue
@@ -129,6 +129,7 @@ import AppLoadingSpinner from 'web-pkg/src/components/AppLoadingSpinner.vue'
 import EditQuota from 'web-pkg/src/mixins/spaces/editQuota'
 import { toRaw } from 'vue'
 import { SpaceResource } from 'web-client/src'
+import { useGettext } from 'vue3-gettext'
 
 export default defineComponent({
   name: 'UsersView',
@@ -144,7 +145,7 @@ export default defineComponent({
   mixins: [Delete, EditQuota],
   setup() {
     const instance = getCurrentInstance().proxy as any
-    const $gettext = instance.$gettext
+    const { $gettext } = useGettext()
     const store = useStore()
     const accessToken = useAccessToken({ store })
     const { graphClient } = useGraphClient()
@@ -217,10 +218,13 @@ export default defineComponent({
           Object.assign(user, additionalUserData)
           if (unref(selectedUsers).length === 1) {
             loadedUser.value = additionalUserData
+            sideBarLoading.value = false
             return
           }
-          loadedUser.value = null
         })
+        if (unref(selectedUsers).length !== 1) {
+          loadedUser.value = null
+        }
         sideBarLoading.value = false
         selectedPersonalDrives.value.splice(0, unref(selectedPersonalDrives).length)
         unref(selectedUsers).forEach((user) => {
diff --git a/packages/web-pkg/src/components/Spaces/QuotaModal.vue b/packages/web-pkg/src/components/Spaces/QuotaModal.vue
index 1b3d287b650..92001ed5397 100644
--- a/packages/web-pkg/src/components/Spaces/QuotaModal.vue
+++ b/packages/web-pkg/src/components/Spaces/QuotaModal.vue
@@ -20,10 +20,11 @@
 </template>
 
 <script lang="ts">
-import { defineComponent, unref } from 'vue'
+import { defineComponent, unref, PropType } from 'vue'
 import { mapActions, mapMutations } from 'vuex'
 import { useGraphClient } from 'web-pkg/src/composables'
 import QuotaSelect from 'web-pkg/src/components/QuotaSelect.vue'
+import { SpaceResource } from 'web-client/src'
 
 export default defineComponent({
   name: 'SpaceQuotaModal',
@@ -32,7 +33,7 @@ export default defineComponent({
   },
   props: {
     spaces: {
-      type: Array,
+      type: Array as PropType<SpaceResource[]>,
       required: true
     },
     cancel: {

From 17c1d32200e1e49f31e9b8928181599102047503 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 13 Feb 2023 15:06:42 +0100
Subject: [PATCH 10/15] Refactor Quota modal, small bugfix

---
 .../src/views/Spaces.vue                      | 15 ++++
 .../src/components/Spaces/QuotaModal.vue      | 84 ++++++++++++-------
 .../web-pkg/src/mixins/spaces/editQuota.ts    |  7 ++
 3 files changed, 74 insertions(+), 32 deletions(-)

diff --git a/packages/web-app-admin-settings/src/views/Spaces.vue b/packages/web-app-admin-settings/src/views/Spaces.vue
index 39059a4276d..ab2ab14939e 100644
--- a/packages/web-app-admin-settings/src/views/Spaces.vue
+++ b/packages/web-app-admin-settings/src/views/Spaces.vue
@@ -135,6 +135,7 @@ export default defineComponent({
     const { sideBarOpen, sideBarActivePanel } = useSideBar()
 
     const loadResourcesEventToken = ref(null)
+    const updateQuotaForSpaceEventToken = ref(null)
     const template = ref(null)
     const listHeaderPosition = ref(0)
     const selectedSpaces = ref([])
@@ -263,10 +264,24 @@ export default defineComponent({
       calculateListHeaderPosition()
       window.addEventListener('resize', calculateListHeaderPosition)
       resizeObserver.observe(unref(appBarActionsRef))
+
+      updateQuotaForSpaceEventToken.value = eventBus.subscribe(
+        'app.admin-settings.spaces.space.quota.updated',
+        ({ spaceId, quota }) => {
+          const space = unref(spaces).find((s) => s.id === spaceId)
+          if (space) {
+            space.spaceQuota = quota
+          }
+        }
+      )
     })
 
     onBeforeUnmount(() => {
       eventBus.unsubscribe('app.admin-settings.list.load', unref(loadResourcesEventToken))
+      eventBus.unsubscribe(
+        'app.admin-settings.spaces.space.quota.updated',
+        unref(updateQuotaForSpaceEventToken)
+      )
       resizeObserver.unobserve(unref(appBarActionsRef))
     })
 
diff --git a/packages/web-pkg/src/components/Spaces/QuotaModal.vue b/packages/web-pkg/src/components/Spaces/QuotaModal.vue
index 92001ed5397..a4869f2ea15 100644
--- a/packages/web-pkg/src/components/Spaces/QuotaModal.vue
+++ b/packages/web-pkg/src/components/Spaces/QuotaModal.vue
@@ -25,6 +25,7 @@ import { mapActions, mapMutations } from 'vuex'
 import { useGraphClient } from 'web-pkg/src/composables'
 import QuotaSelect from 'web-pkg/src/components/QuotaSelect.vue'
 import { SpaceResource } from 'web-client/src'
+import { eventBus } from 'web-pkg/src'
 
 export default defineComponent({
   name: 'SpaceQuotaModal',
@@ -78,40 +79,59 @@ export default defineComponent({
     changeSelectedQuotaOption(option) {
       this.selectedOption = option.value
     },
-    editQuota() {
-      const requests = []
-      this.spaces.forEach((space) => {
-        const request = this.graphClient.drives
-          .updateDrive(space.id, { quota: { total: this.selectedOption } }, {})
-          .then(({ data }) => {
-            this.cancel()
-            if (unref(this.$router.currentRoute).name === 'admin-settings-spaces') {
-              this.$emit('spaceQuotaUpdated', data.quota)
-            }
-            this.UPDATE_SPACE_FIELD({
-              id: space.id,
-              field: 'spaceQuota',
-              value: data.quota
-            })
-            this.UPDATE_RESOURCE_FIELD({
-              id: space.id,
-              field: 'spaceQuota',
-              value: data.quota
-            })
-            this.showMessage({
-              title: this.$gettext('Space quota was changed successfully')
-            })
-          })
-          .catch((error) => {
-            console.error(error)
-            this.showMessage({
-              title: this.$gettext('Failed to change space quota'),
-              status: 'danger'
-            })
+    async editQuota(): Promise<void> {
+      const requests = this.spaces.map(async (space): Promise<void> => {
+        const { data: driveData } = await this.graphClient.drives.updateDrive(
+          space.id,
+          { quota: { total: this.selectedOption } },
+          {}
+        )
+        this.cancel()
+        if (unref(this.$router.currentRoute).name === 'admin-settings-spaces') {
+          eventBus.publish('app.admin-settings.spaces.space.quota.updated', {
+            spaceId: space.id,
+            quota: driveData.quota
           })
-        requests.push(request)
+        }
+        this.UPDATE_SPACE_FIELD({
+          id: space.id,
+          field: 'spaceQuota',
+          value: driveData.quota
+        })
+        this.UPDATE_RESOURCE_FIELD({
+          id: space.id,
+          field: 'spaceQuota',
+          value: driveData.quota
+        })
       })
-      return Promise.all(requests)
+      const results = await Promise.allSettled<Array<unknown>>(requests)
+      const succeeded = results.filter((r) => r.status === 'fulfilled')
+      if (succeeded.length) {
+        this.showMessage({
+          title: this.$ngettext(
+            'Space quota was changed successfully',
+            'Space quota of %{count} spaces was changed successfully',
+            succeeded.length,
+            {
+              count: succeeded.length
+            }
+          )
+        })
+      }
+      const errors = results.filter((r) => r.status === 'rejected')
+      if (errors.length) {
+        errors.forEach(console.error)
+        this.showMessage({
+          title: this.$ngettext(
+            'Failed to change space quota',
+            'Failed to change space quota for %{count} spaces',
+            errors.length,
+            {
+              count: errors.length
+            }
+          )
+        })
+      }
     }
   }
 })
diff --git a/packages/web-pkg/src/mixins/spaces/editQuota.ts b/packages/web-pkg/src/mixins/spaces/editQuota.ts
index bef4025dc92..59861537bfc 100644
--- a/packages/web-pkg/src/mixins/spaces/editQuota.ts
+++ b/packages/web-pkg/src/mixins/spaces/editQuota.ts
@@ -21,6 +21,13 @@ export default {
           },
           handler: this.$_editQuota_trigger,
           isEnabled: ({ resources }) => {
+            if (!resources.length) {
+              return false
+            }
+            const isProjectSpace = 'spaceQuota' in resources[0]
+            if (resources.length === 1 && !isProjectSpace && !resources[0].drive?.quota) {
+              return false
+            }
             if (resources.some((r) => r.spaceQuota === false)) {
               return false
             }

From 19fc70e313da7d2092d857e967dd5d03bb571ba4 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 13 Feb 2023 16:05:06 +0100
Subject: [PATCH 11/15] Fix some test

---
 .../tests/unit/views/Spaces.spec.ts           |  6 +--
 .../tests/unit/views/Users.spec.ts            | 11 ++++--
 .../views/__snapshots__/Spaces.spec.ts.snap   |  1 +
 .../components/Spaces/SpaceHeader.spec.ts     | 10 ++++-
 .../__snapshots__/SpaceHeader.spec.ts.snap    | 39 +++++++++++++++++++
 .../web-pkg/src/mixins/spaces/editQuota.ts    |  2 +-
 6 files changed, 59 insertions(+), 10 deletions(-)

diff --git a/packages/web-app-admin-settings/tests/unit/views/Spaces.spec.ts b/packages/web-app-admin-settings/tests/unit/views/Spaces.spec.ts
index 8797617ca89..66deabbab90 100644
--- a/packages/web-app-admin-settings/tests/unit/views/Spaces.spec.ts
+++ b/packages/web-app-admin-settings/tests/unit/views/Spaces.spec.ts
@@ -27,7 +27,7 @@ const selectors = {
   batchActionsStub: 'batch-actions-stub'
 }
 
-const mixins = ['$_disable_items', '$_restore_items', '$_delete_items']
+const mixins = ['$_disable_items', '$_restore_items', '$_delete_items', '$_editQuota_items']
 jest.mock('web-pkg/src/composables/appDefaults')
 
 describe('Spaces view', () => {
@@ -51,8 +51,8 @@ describe('Spaces view', () => {
     expect(wrapper.find(selectors.noContentMessageStub).exists()).toBeTruthy()
   })
   describe('toggle selection', () => {
-    describe('toggleSelectAllSpaces method', () => {
-      it('selects all spaces', async () => {
+    fdescribe('toggleSelectAllSpaces method', () => {
+      fit('selects all spaces', async () => {
         const spaces = [{ name: 'Some Space' }]
         const { wrapper } = getWrapper({ spaces })
         await wrapper.vm.loadResourcesTask.last
diff --git a/packages/web-app-admin-settings/tests/unit/views/Users.spec.ts b/packages/web-app-admin-settings/tests/unit/views/Users.spec.ts
index 9fb04d68456..bdf79d14250 100644
--- a/packages/web-app-admin-settings/tests/unit/views/Users.spec.ts
+++ b/packages/web-app-admin-settings/tests/unit/views/Users.spec.ts
@@ -8,12 +8,14 @@ import {
   defaultComponentMocks,
   defaultPlugins,
   defaultStoreMockOptions,
+  getActionMixinMocks,
   mount,
   shallowMount
 } from 'web-test-helpers'
 import { AxiosResponse } from 'axios'
 import { queryItemAsString } from 'web-pkg'
 
+const mixins = ['$_editQuota_items']
 jest.mock('web-pkg/src/composables/appDefaults')
 
 const getDefaultUser = () => {
@@ -323,11 +325,11 @@ describe('Users view', () => {
       expect(wrapper.find('batch-actions-stub').exists()).toBeTruthy()
     })
     it('display when more than one users selected', async () => {
-      const { wrapper } = getMountedWrapper({ mountType: mount })
+      /*const { wrapper } = getMountedWrapper({ mountType: mount })
       await wrapper.vm.loadResourcesTask.last
       wrapper.vm.toggleSelectAllUsers()
       await wrapper.vm.$nextTick()
-      expect(wrapper.find('batch-actions-stub').exists()).toBeTruthy()
+      expect(wrapper.find('batch-actions-stub').exists()).toBeTruthy()*/
     })
   })
 
@@ -373,7 +375,8 @@ function getMountedWrapper({
 } = {}) {
   jest.mocked(queryItemAsString).mockImplementation(() => queryItem)
   const mocks = {
-    ...defaultComponentMocks()
+    ...defaultComponentMocks(),
+    ...getActionMixinMocks({ actions: mixins })
   }
   mocks.$clientService.graphAuthenticated.mockImplementation(() => graph)
 
@@ -388,7 +391,7 @@ function getMountedWrapper({
 
   return {
     mocks,
-    wrapper: mountType(Users, {
+    wrapper: mountType({...Users, mixins}, {
       global: {
         plugins: [...defaultPlugins(), store],
         mocks,
diff --git a/packages/web-app-admin-settings/tests/unit/views/__snapshots__/Spaces.spec.ts.snap b/packages/web-app-admin-settings/tests/unit/views/__snapshots__/Spaces.spec.ts.snap
index 9c1754e6408..813fcec5969 100644
--- a/packages/web-app-admin-settings/tests/unit/views/__snapshots__/Spaces.spec.ts.snap
+++ b/packages/web-app-admin-settings/tests/unit/views/__snapshots__/Spaces.spec.ts.snap
@@ -20,6 +20,7 @@ exports[`Spaces view loading states should render spaces list after loading has
           <!--v-if-->
         </div>
       </div>
+      <!--v-if-->
       <div>
         <spaces-list-stub class="" headerposition="0" selectedspaces="" spaces="[object Object]"></spaces-list-stub>
       </div>
diff --git a/packages/web-app-files/tests/unit/components/Spaces/SpaceHeader.spec.ts b/packages/web-app-files/tests/unit/components/Spaces/SpaceHeader.spec.ts
index c12b15c5111..189823ba871 100644
--- a/packages/web-app-files/tests/unit/components/Spaces/SpaceHeader.spec.ts
+++ b/packages/web-app-files/tests/unit/components/Spaces/SpaceHeader.spec.ts
@@ -43,7 +43,10 @@ describe('SpaceHeader', () => {
 
 function getWrapper({ space = {}, sideBarOpen = false }) {
   const mocks = {
-    ...defaultComponentMocks()
+    ...defaultComponentMocks(),
+    $permissionManager: {
+      canEditSpaceQuota: () => true
+    }
   }
   const store = createStore(defaultStoreMockOptions)
   return mount(SpaceHeader, {
@@ -53,7 +56,10 @@ function getWrapper({ space = {}, sideBarOpen = false }) {
     },
     global: {
       mocks,
-      plugins: [...defaultPlugins(), store]
+      plugins: [...defaultPlugins(), store],
+      stubs: {
+        'quota-modal': true
+      }
     }
   })
 }
diff --git a/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceHeader.spec.ts.snap b/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceHeader.spec.ts.snap
index 0575384695f..7f3a98095c5 100644
--- a/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceHeader.spec.ts.snap
+++ b/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceHeader.spec.ts.snap
@@ -36,6 +36,19 @@ exports[`SpaceHeader should add the "squashed"-class when the sidebar is opened
                     </button>
                   </li>
                 </ul>
+                <ul class="oc-list oc-my-rm oc-mx-rm oc-files-context-actions oc-pb-s oc-pt-s oc-files-context-actions-border" id="oc-files-context-actions-secondaryActions">
+                  <li class="context-menu oc-files-context-action oc-px-s oc-rounded oc-menu-item-hover">
+                    <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-center oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-edit-quota-trigger action-menu-item" type="button">
+                      <!-- @slot Content of the button -->
+                      <span class="oc-icon oc-icon-m oc-icon-passive">
+                        <!---->
+                      </span>
+                      <span class="oc-files-context-action-label">Edit quota</span>
+                      <!--v-if-->
+                      <!--v-if-->
+                    </button>
+                  </li>
+                </ul>
                 <ul class="oc-list oc-my-rm oc-mx-rm oc-files-context-actions oc-pt-s" id="oc-files-context-actions-trashBin">
                   <li class="context-menu oc-files-context-action oc-px-s oc-rounded oc-menu-item-hover">
                     <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-left oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-delete-trigger action-menu-item oc-py-s oc-px-m oc-width-1-1" type="button">
@@ -105,6 +118,19 @@ exports[`SpaceHeader space image should show the default image if no other image
                     </button>
                   </li>
                 </ul>
+                <ul class="oc-list oc-my-rm oc-mx-rm oc-files-context-actions oc-pb-s oc-pt-s oc-files-context-actions-border" id="oc-files-context-actions-secondaryActions">
+                  <li class="context-menu oc-files-context-action oc-px-s oc-rounded oc-menu-item-hover">
+                    <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-center oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-edit-quota-trigger action-menu-item" type="button">
+                      <!-- @slot Content of the button -->
+                      <span class="oc-icon oc-icon-m oc-icon-passive">
+                        <!---->
+                      </span>
+                      <span class="oc-files-context-action-label">Edit quota</span>
+                      <!--v-if-->
+                      <!--v-if-->
+                    </button>
+                  </li>
+                </ul>
                 <ul class="oc-list oc-my-rm oc-mx-rm oc-files-context-actions oc-pt-s" id="oc-files-context-actions-trashBin">
                   <li class="context-menu oc-files-context-action oc-px-s oc-rounded oc-menu-item-hover">
                     <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-left oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-delete-trigger action-menu-item oc-py-s oc-px-m oc-width-1-1" type="button">
@@ -170,6 +196,19 @@ exports[`SpaceHeader space image should show the set image 1`] = `
                     </button>
                   </li>
                 </ul>
+                <ul class="oc-list oc-my-rm oc-mx-rm oc-files-context-actions oc-pb-s oc-pt-s oc-files-context-actions-border" id="oc-files-context-actions-secondaryActions">
+                  <li class="context-menu oc-files-context-action oc-px-s oc-rounded oc-menu-item-hover">
+                    <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-center oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-edit-quota-trigger action-menu-item" type="button">
+                      <!-- @slot Content of the button -->
+                      <span class="oc-icon oc-icon-m oc-icon-passive">
+                        <!---->
+                      </span>
+                      <span class="oc-files-context-action-label">Edit quota</span>
+                      <!--v-if-->
+                      <!--v-if-->
+                    </button>
+                  </li>
+                </ul>
                 <ul class="oc-list oc-my-rm oc-mx-rm oc-files-context-actions oc-pt-s" id="oc-files-context-actions-trashBin">
                   <li class="context-menu oc-files-context-action oc-px-s oc-rounded oc-menu-item-hover">
                     <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-left oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-delete-trigger action-menu-item oc-py-s oc-px-m oc-width-1-1" type="button">
diff --git a/packages/web-pkg/src/mixins/spaces/editQuota.ts b/packages/web-pkg/src/mixins/spaces/editQuota.ts
index 59861537bfc..dcb787fe3ab 100644
--- a/packages/web-pkg/src/mixins/spaces/editQuota.ts
+++ b/packages/web-pkg/src/mixins/spaces/editQuota.ts
@@ -21,7 +21,7 @@ export default {
           },
           handler: this.$_editQuota_trigger,
           isEnabled: ({ resources }) => {
-            if (!resources.length) {
+            if (!resources || !resources.length) {
               return false
             }
             const isProjectSpace = 'spaceQuota' in resources[0]

From 2063b9dabc634b887eee5fb9885ae6e7253e24ee Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 13 Feb 2023 16:25:05 +0100
Subject: [PATCH 12/15] Fix unittests

---
 .../tests/unit/views/Spaces.spec.ts           |  4 +--
 .../tests/unit/views/Users.spec.ts            | 11 +++++---
 .../Spaces/SpaceContextActions.spec.ts        |  5 +++-
 .../SpaceContextActions.spec.ts.snap          | 13 ++++++++++
 .../unit/components/Spaces/QuotaModal.spec.ts | 26 ++++++++++++-------
 5 files changed, 43 insertions(+), 16 deletions(-)

diff --git a/packages/web-app-admin-settings/tests/unit/views/Spaces.spec.ts b/packages/web-app-admin-settings/tests/unit/views/Spaces.spec.ts
index 66deabbab90..7433d047252 100644
--- a/packages/web-app-admin-settings/tests/unit/views/Spaces.spec.ts
+++ b/packages/web-app-admin-settings/tests/unit/views/Spaces.spec.ts
@@ -51,8 +51,8 @@ describe('Spaces view', () => {
     expect(wrapper.find(selectors.noContentMessageStub).exists()).toBeTruthy()
   })
   describe('toggle selection', () => {
-    fdescribe('toggleSelectAllSpaces method', () => {
-      fit('selects all spaces', async () => {
+    describe('toggleSelectAllSpaces method', () => {
+      it('selects all spaces', async () => {
         const spaces = [{ name: 'Some Space' }]
         const { wrapper } = getWrapper({ spaces })
         await wrapper.vm.loadResourcesTask.last
diff --git a/packages/web-app-admin-settings/tests/unit/views/Users.spec.ts b/packages/web-app-admin-settings/tests/unit/views/Users.spec.ts
index bdf79d14250..13895b4a2dc 100644
--- a/packages/web-app-admin-settings/tests/unit/views/Users.spec.ts
+++ b/packages/web-app-admin-settings/tests/unit/views/Users.spec.ts
@@ -15,7 +15,7 @@ import {
 import { AxiosResponse } from 'axios'
 import { queryItemAsString } from 'web-pkg'
 
-const mixins = ['$_editQuota_items']
+const mixins = ['$_delete_items', '$_editQuota_items']
 jest.mock('web-pkg/src/composables/appDefaults')
 
 const getDefaultUser = () => {
@@ -325,11 +325,11 @@ describe('Users view', () => {
       expect(wrapper.find('batch-actions-stub').exists()).toBeTruthy()
     })
     it('display when more than one users selected', async () => {
-      /*const { wrapper } = getMountedWrapper({ mountType: mount })
+      const { wrapper } = getMountedWrapper({ mountType: mount })
       await wrapper.vm.loadResourcesTask.last
       wrapper.vm.toggleSelectAllUsers()
       await wrapper.vm.$nextTick()
-      expect(wrapper.find('batch-actions-stub').exists()).toBeTruthy()*/
+      expect(wrapper.find('batch-actions-stub').exists()).toBeTruthy()
     })
   })
 
@@ -399,11 +399,14 @@ function getMountedWrapper({
           CreateUserModal: true,
           AppLoadingSpinner: true,
           OcBreadcrumb: true,
+          NoContentMessage: true,
           OcTable: true,
           ItemFilter: true,
           BatchActions: true
+    
         }
       }
-    })
+    }
+    )
   }
 }
diff --git a/packages/web-app-files/tests/unit/components/Spaces/SpaceContextActions.spec.ts b/packages/web-app-files/tests/unit/components/Spaces/SpaceContextActions.spec.ts
index eddb92d5ca4..1597636d1ba 100644
--- a/packages/web-app-files/tests/unit/components/Spaces/SpaceContextActions.spec.ts
+++ b/packages/web-app-files/tests/unit/components/Spaces/SpaceContextActions.spec.ts
@@ -34,7 +34,10 @@ function getWrapper(space) {
       },
       global: {
         mocks: {
-          ...defaultComponentMocks({ currentRoute: mock<RouteLocation>({ path: '/files' }) })
+          ...defaultComponentMocks({ currentRoute: mock<RouteLocation>({ path: '/files' }) }),
+          $permissionManager: {
+            canEditSpaceQuota: () => true
+          }
         },
         plugins: [...defaultPlugins(), store]
       }
diff --git a/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceContextActions.spec.ts.snap b/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceContextActions.spec.ts.snap
index a69115ba5df..0e7788a2f5e 100644
--- a/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceContextActions.spec.ts.snap
+++ b/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceContextActions.spec.ts.snap
@@ -16,6 +16,19 @@ exports[`SpaceContextActions action handlers renders actions that are always ava
         </button>
       </li>
     </ul>
+    <ul class="oc-list oc-my-rm oc-mx-rm oc-files-context-actions oc-pb-s oc-pt-s oc-files-context-actions-border" id="oc-files-context-actions-secondaryActions">
+      <li class="context-menu oc-files-context-action oc-px-s oc-rounded oc-menu-item-hover">
+        <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-center oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-edit-quota-trigger action-menu-item" type="button">
+          <!-- @slot Content of the button -->
+          <span class="oc-icon oc-icon-m oc-icon-passive">
+            <!---->
+          </span>
+          <span class="oc-files-context-action-label">Edit quota</span>
+          <!--v-if-->
+          <!--v-if-->
+        </button>
+      </li>
+    </ul>
     <ul class="oc-list oc-my-rm oc-mx-rm oc-files-context-actions oc-pb-s oc-pt-s oc-files-context-actions-border" id="oc-files-context-actions-trashBin">
       <li class="context-menu oc-files-context-action oc-px-s oc-rounded oc-menu-item-hover">
         <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-left oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-delete-trigger action-menu-item oc-py-s oc-px-m oc-width-1-1" type="button">
diff --git a/packages/web-pkg/tests/unit/components/Spaces/QuotaModal.spec.ts b/packages/web-pkg/tests/unit/components/Spaces/QuotaModal.spec.ts
index d69a7ef7972..46256ddf3db 100644
--- a/packages/web-pkg/tests/unit/components/Spaces/QuotaModal.spec.ts
+++ b/packages/web-pkg/tests/unit/components/Spaces/QuotaModal.spec.ts
@@ -74,19 +74,27 @@ function getWrapper(graphMock) {
       },
       props: {
         cancel: jest.fn(),
-        space: {
-          id: '1fe58d8b-aa69-4c22-baf7-97dd57479f22',
-          spaceQuota: {
-            remaining: 9999999836,
-            state: 'normal',
-            total: 10000000000,
-            used: 164
+        spaces: [
+          {
+            id: '1fe58d8b-aa69-4c22-baf7-97dd57479f22',
+            spaceQuota: {
+              remaining: 9999999836,
+              state: 'normal',
+              total: 10000000000,
+              used: 164
+            }
           }
-        }
+        ]
       },
       global: {
         stubs: { ...defaultStubs, portal: true, 'oc-modal': true },
-        mocks: { ...defaultComponentMocks(), $clientService },
+        mocks: {
+          ...defaultComponentMocks(),
+          $clientService,
+          $permissionManager: {
+            canEditSpaceQuota: () => true
+          }
+        },
         plugins: [...defaultPlugins(), store]
       }
     })

From 39a975fc8507f087951c7f6f15ab747e1b6bec71 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 13 Feb 2023 17:17:54 +0100
Subject: [PATCH 13/15] Fix rebase error

---
 .../components/General/AppearanceSection.vue  |  2 +-
 .../src/views/Users.vue                       |  4 ++-
 .../tests/unit/views/Users.spec.ts            | 29 ++++++++++---------
 .../ContextActions/ActionMenuItem.vue         |  2 +-
 pnpm-lock.yaml                                | 12 ++------
 .../app-admin-settings/spaces/actions.ts      |  2 +-
 6 files changed, 23 insertions(+), 28 deletions(-)

diff --git a/packages/web-app-admin-settings/src/components/General/AppearanceSection.vue b/packages/web-app-admin-settings/src/components/General/AppearanceSection.vue
index 9d596e1f91f..123030fce6c 100644
--- a/packages/web-app-admin-settings/src/components/General/AppearanceSection.vue
+++ b/packages/web-app-admin-settings/src/components/General/AppearanceSection.vue
@@ -51,10 +51,10 @@ import { useStore } from 'web-pkg'
 
 export default defineComponent({
   name: 'AppearanceSection',
-  mixins: [UploadLogo, ResetLogo],
   components: {
     ContextActionMenu
   },
+  mixins: [UploadLogo, ResetLogo],
   setup() {
     const store = useStore()
     const instance = getCurrentInstance().proxy as any
diff --git a/packages/web-app-admin-settings/src/views/Users.vue b/packages/web-app-admin-settings/src/views/Users.vue
index 4cc400f9ac2..cf94f2c7136 100644
--- a/packages/web-app-admin-settings/src/views/Users.vue
+++ b/packages/web-app-admin-settings/src/views/Users.vue
@@ -101,6 +101,7 @@ import ContextActions from '../components/Users/ContextActions.vue'
 import DetailsPanel from '../components/Users/SideBar/DetailsPanel.vue'
 import EditPanel from '../components/Users/SideBar/EditPanel.vue'
 import BatchActions from 'web-pkg/src/components/BatchActions.vue'
+import QuotaModal from 'web-pkg/src/components/Spaces/QuotaModal.vue'
 import Delete from '../mixins/users/delete'
 import {
   queryItemAsString,
@@ -140,7 +141,8 @@ export default defineComponent({
     CreateUserModal,
     BatchActions,
     ContextActions,
-    ItemFilter
+    ItemFilter,
+    QuotaModal
   },
   mixins: [Delete, EditQuota],
   setup() {
diff --git a/packages/web-app-admin-settings/tests/unit/views/Users.spec.ts b/packages/web-app-admin-settings/tests/unit/views/Users.spec.ts
index 13895b4a2dc..8ee773617f0 100644
--- a/packages/web-app-admin-settings/tests/unit/views/Users.spec.ts
+++ b/packages/web-app-admin-settings/tests/unit/views/Users.spec.ts
@@ -391,22 +391,23 @@ function getMountedWrapper({
 
   return {
     mocks,
-    wrapper: mountType({...Users, mixins}, {
-      global: {
-        plugins: [...defaultPlugins(), store],
-        mocks,
-        stubs: {
-          CreateUserModal: true,
-          AppLoadingSpinner: true,
-          OcBreadcrumb: true,
-          NoContentMessage: true,
-          OcTable: true,
-          ItemFilter: true,
-          BatchActions: true
-    
+    wrapper: mountType(
+      { ...Users, mixins },
+      {
+        global: {
+          plugins: [...defaultPlugins(), store],
+          mocks,
+          stubs: {
+            CreateUserModal: true,
+            AppLoadingSpinner: true,
+            OcBreadcrumb: true,
+            NoContentMessage: true,
+            OcTable: true,
+            ItemFilter: true,
+            BatchActions: true
+          }
         }
       }
-    }
     )
   }
 }
diff --git a/packages/web-pkg/src/components/ContextActions/ActionMenuItem.vue b/packages/web-pkg/src/components/ContextActions/ActionMenuItem.vue
index 0e4edf476c7..347be9a7fc2 100644
--- a/packages/web-pkg/src/components/ContextActions/ActionMenuItem.vue
+++ b/packages/web-pkg/src/components/ContextActions/ActionMenuItem.vue
@@ -7,8 +7,8 @@
       :class="[action.class, 'action-menu-item', 'oc-py-s', 'oc-px-m', 'oc-width-1-1']"
       data-testid="action-handler"
       size="small"
-      v-on="componentListeners"
       justify-content="left"
+      v-on="componentListeners"
     >
       <oc-img
         v-if="action.img"
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 07caa32e0e0..3127b1d2cf2 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -8184,7 +8184,7 @@ packages:
       minipass-pipeline: 1.2.4
       mkdirp: 1.0.4
       p-map: 4.0.0
-      promise-inflight: 1.0.1
+      promise-inflight: 1.0.1_bluebird@3.7.2
       rimraf: 3.0.2
       ssri: 8.0.1
       tar: 6.1.13
@@ -18427,15 +18427,6 @@ packages:
     engines: {node: '>=0.4.0'}
     dev: true
 
-  /promise-inflight/1.0.1:
-    resolution: {integrity: sha512-6zWPyEOFaQBJYcGMHBKTKJ3u6TBsnMFOIZSa6ce1e/ZrrsOlnHRHbabMjLiBYKp+n44X9eUI6VUPaukCXHuG4g==}
-    peerDependencies:
-      bluebird: '*'
-    peerDependenciesMeta:
-      bluebird:
-        optional: true
-    dev: true
-
   /promise-inflight/1.0.1_bluebird@3.7.2:
     resolution: {integrity: sha512-6zWPyEOFaQBJYcGMHBKTKJ3u6TBsnMFOIZSa6ce1e/ZrrsOlnHRHbabMjLiBYKp+n44X9eUI6VUPaukCXHuG4g==}
     peerDependencies:
@@ -18684,6 +18675,7 @@ packages:
     engines: {node: '>=0.6'}
     dependencies:
       side-channel: 1.0.4
+    dev: true
 
   /qs/6.5.3:
     resolution: {integrity: sha512-qxXIEh4pCGfHICj1mAJQ2/2XVZkjCDTcEgfoSQxc/fYivUZxTkk7L3bDBJSoNrEzXI17oUO5Dp07ktqE5KzczA==}
diff --git a/tests/e2e/support/objects/app-admin-settings/spaces/actions.ts b/tests/e2e/support/objects/app-admin-settings/spaces/actions.ts
index 9f0e5470cfa..63155c107b4 100644
--- a/tests/e2e/support/objects/app-admin-settings/spaces/actions.ts
+++ b/tests/e2e/support/objects/app-admin-settings/spaces/actions.ts
@@ -5,7 +5,7 @@ const spaceTrSelector = 'tr'
 const actionConfirmButton = '.oc-modal-body-actions-confirm'
 const spaceIdSelector = `[data-item-id="%s"] .spaces-table-btn-action-dropdown`
 const spaceCheckboxSelector = `[data-item-id="%s"]:not(.oc-table-highlighted) input[type=checkbox]`
-const quotaActionBtn = `.oc-files-actions-edit-quota-trigger`
+const quotaActionBtn = `(.oc-files-actions-edit-quota-trigger)[1]`
 const disableActionBtn = `.oc-files-actions-disable-trigger`
 const deleteActionBtn = `.oc-files-actions-delete-trigger`
 const modalConfirmBtn = `.oc-modal-body-actions-confirm`

From 9a373d72d0c35cb07eb9dadab1a071a2dc403420 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 13 Feb 2023 17:30:14 +0100
Subject: [PATCH 14/15] Update snapshots

---
 .../Spaces/__snapshots__/SpaceContextActions.spec.ts.snap   | 2 +-
 .../Spaces/__snapshots__/SpaceHeader.spec.ts.snap           | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceContextActions.spec.ts.snap b/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceContextActions.spec.ts.snap
index 0e7788a2f5e..92583e071e8 100644
--- a/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceContextActions.spec.ts.snap
+++ b/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceContextActions.spec.ts.snap
@@ -18,7 +18,7 @@ exports[`SpaceContextActions action handlers renders actions that are always ava
     </ul>
     <ul class="oc-list oc-my-rm oc-mx-rm oc-files-context-actions oc-pb-s oc-pt-s oc-files-context-actions-border" id="oc-files-context-actions-secondaryActions">
       <li class="context-menu oc-files-context-action oc-px-s oc-rounded oc-menu-item-hover">
-        <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-center oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-edit-quota-trigger action-menu-item" type="button">
+        <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-left oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-edit-quota-trigger action-menu-item oc-py-s oc-px-m oc-width-1-1" type="button">
           <!-- @slot Content of the button -->
           <span class="oc-icon oc-icon-m oc-icon-passive">
             <!---->
diff --git a/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceHeader.spec.ts.snap b/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceHeader.spec.ts.snap
index 7f3a98095c5..82773ea7ef2 100644
--- a/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceHeader.spec.ts.snap
+++ b/packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceHeader.spec.ts.snap
@@ -38,7 +38,7 @@ exports[`SpaceHeader should add the "squashed"-class when the sidebar is opened
                 </ul>
                 <ul class="oc-list oc-my-rm oc-mx-rm oc-files-context-actions oc-pb-s oc-pt-s oc-files-context-actions-border" id="oc-files-context-actions-secondaryActions">
                   <li class="context-menu oc-files-context-action oc-px-s oc-rounded oc-menu-item-hover">
-                    <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-center oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-edit-quota-trigger action-menu-item" type="button">
+                    <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-left oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-edit-quota-trigger action-menu-item oc-py-s oc-px-m oc-width-1-1" type="button">
                       <!-- @slot Content of the button -->
                       <span class="oc-icon oc-icon-m oc-icon-passive">
                         <!---->
@@ -120,7 +120,7 @@ exports[`SpaceHeader space image should show the default image if no other image
                 </ul>
                 <ul class="oc-list oc-my-rm oc-mx-rm oc-files-context-actions oc-pb-s oc-pt-s oc-files-context-actions-border" id="oc-files-context-actions-secondaryActions">
                   <li class="context-menu oc-files-context-action oc-px-s oc-rounded oc-menu-item-hover">
-                    <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-center oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-edit-quota-trigger action-menu-item" type="button">
+                    <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-left oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-edit-quota-trigger action-menu-item oc-py-s oc-px-m oc-width-1-1" type="button">
                       <!-- @slot Content of the button -->
                       <span class="oc-icon oc-icon-m oc-icon-passive">
                         <!---->
@@ -198,7 +198,7 @@ exports[`SpaceHeader space image should show the set image 1`] = `
                 </ul>
                 <ul class="oc-list oc-my-rm oc-mx-rm oc-files-context-actions oc-pb-s oc-pt-s oc-files-context-actions-border" id="oc-files-context-actions-secondaryActions">
                   <li class="context-menu oc-files-context-action oc-px-s oc-rounded oc-menu-item-hover">
-                    <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-center oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-edit-quota-trigger action-menu-item" type="button">
+                    <button class="oc-button oc-rounded oc-button-s oc-button-justify-content-left oc-button-gap-m oc-button-passive oc-button-passive-raw oc-files-actions-edit-quota-trigger action-menu-item oc-py-s oc-px-m oc-width-1-1" type="button">
                       <!-- @slot Content of the button -->
                       <span class="oc-icon oc-icon-m oc-icon-passive">
                         <!---->

From 00311d4e88497b5a5323d7d9402854f53dcbe188 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Tue, 14 Feb 2023 09:55:59 +0100
Subject: [PATCH 15/15] Fix acceptance test

---
 .../e2e/support/objects/app-admin-settings/spaces/actions.ts  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/e2e/support/objects/app-admin-settings/spaces/actions.ts b/tests/e2e/support/objects/app-admin-settings/spaces/actions.ts
index 63155c107b4..58d2530d964 100644
--- a/tests/e2e/support/objects/app-admin-settings/spaces/actions.ts
+++ b/tests/e2e/support/objects/app-admin-settings/spaces/actions.ts
@@ -5,7 +5,7 @@ const spaceTrSelector = 'tr'
 const actionConfirmButton = '.oc-modal-body-actions-confirm'
 const spaceIdSelector = `[data-item-id="%s"] .spaces-table-btn-action-dropdown`
 const spaceCheckboxSelector = `[data-item-id="%s"]:not(.oc-table-highlighted) input[type=checkbox]`
-const quotaActionBtn = `(.oc-files-actions-edit-quota-trigger)[1]`
+const quotaActionBtn = `.oc-files-actions-edit-quota-trigger`
 const disableActionBtn = `.oc-files-actions-disable-trigger`
 const deleteActionBtn = `.oc-files-actions-delete-trigger`
 const modalConfirmBtn = `.oc-modal-body-actions-confirm`
@@ -33,7 +33,7 @@ export const changeSpaceQuota = async (args: {
   const { page, value, id } = args
   await page.locator(util.format(spaceIdSelector, id)).click()
   await page.waitForSelector(quotaActionBtn)
-  await page.locator(quotaActionBtn).click()
+  await page.locator(`.context-menu`).locator(quotaActionBtn).click()
 
   const searchLocator = await page.locator(spacesQuotaSearchField)
   await searchLocator.fill(value)