Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix re-using space images #8084

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fix re-using space images #8084

merged 1 commit into from
Dec 9, 2022

Conversation

JammingBen
Copy link
Contributor

Description

We've fixed a bug where re-using a previously used space image via "Set as space image" would cause errors.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Dec 8, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.5% 82.5% Coverage
0.0% 0.0% Duplication

dschmidt
dschmidt reviewed Dec 8, 2022
View reviewed changes
packages/web-app-files/src/mixins/spaces/actions/setImage.ts
this.space,
{ path: destinationPath },
{ overwrite: true }
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @dschmidt 😅 😍

lookacat
lookacat approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

kulmann
kulmann approved these changes Dec 9, 2022
View reviewed changes
packages/web-app-files/src/mixins/spaces/actions/setImage.ts
this.space,
{ path: destinationPath },
{ overwrite: true }
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @dschmidt 😅 😍

@kulmann kulmann merged commit 7629c98 into stable-6.0 Dec 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-space-set-image branch December 9, 2022 09:30
ownclouders pushed a commit that referenced this pull request Dec 9, 2022
@kulmann
commit 7629c98
6c393bd 
Merge: bcc9f21 bac84eb
Author: Benedikt Kulmann <[email protected]>
Date:   Fri Dec 9 10:29:57 2022 +0100

    Merge pull request #8084 from owncloud/fix-space-set-image

    Fix re-using space images
@JammingBen JammingBen mentioned this pull request Dec 9, 2022
Closed
ownclouders pushed a commit that referenced this pull request Dec 10, 2022
@kulmann
commit 7629c98
1eb75f5 
Merge: bcc9f21 bac84eb
Author: Benedikt Kulmann <[email protected]>
Date:   Fri Dec 9 10:29:57 2022 +0100

    Merge pull request #8084 from owncloud/fix-space-set-image

    Fix re-using space images
ownclouders pushed a commit that referenced this pull request Dec 11, 2022
@kulmann
commit 7629c98
6488c85 
Merge: bcc9f21 bac84eb
Author: Benedikt Kulmann <[email protected]>
Date:   Fri Dec 9 10:29:57 2022 +0100

    Merge pull request #8084 from owncloud/fix-space-set-image

    Fix re-using space images
ownclouders pushed a commit that referenced this pull request Dec 12, 2022
@kulmann
commit 7629c98
b045ca4 
Merge: bcc9f21 bac84eb
Author: Benedikt Kulmann <[email protected]>
Date:   Fri Dec 9 10:29:57 2022 +0100

    Merge pull request #8084 from owncloud/fix-space-set-image

    Fix re-using space images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt left review comments

@kulmann kulmann kulmann approved these changes

@lookacat lookacat lookacat approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JammingBen @dschmidt @lookacat @kulmann