From 52acc257c8eaaaa8c117b94fd282174225b8b03d Mon Sep 17 00:00:00 2001 From: Jan Date: Thu, 1 Dec 2022 09:19:13 +0100 Subject: [PATCH 01/15] Preload images --- packages/web-app-preview/src/App.vue | 37 +++++++++++++++++++++++----- 1 file changed, 31 insertions(+), 6 deletions(-) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index ba097359efe..8f24eb483b5 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -383,6 +383,7 @@ export default defineComponent({ await this.loadFolderForFileContext(this.currentFileContext) this.setActiveFile(this.currentFileContext.driveAliasAndItem) this.$refs.preview.focus() + this.preloadImages() }, beforeDestroy() { @@ -409,19 +410,16 @@ export default defineComponent({ this.isFileContentLoading = false this.isFileContentError = true }, - // react to PopStateEvent () handleLocalHistoryEvent() { const result = this.$router.resolve(document.location) this.setActiveFile(result.route.params.driveAliasAndItem) }, - handleFullScreenChangeEvent() { if (document.fullscreenElement === null) { this.isFullScreenModeActivated = false } }, - // update route and url updateLocalHistory() { const routeOptions = mergeFileRouteOptions( @@ -430,7 +428,6 @@ export default defineComponent({ ) history.pushState({}, document.title, this.$router.resolve(routeOptions).href) }, - loadMedium() { this.isFileContentLoading = true @@ -448,7 +445,6 @@ export default defineComponent({ this.loadActiveFileIntoCache() }, - async loadActiveFileIntoCache() { try { const loadRawFile = !this.isActiveFileTypeImage @@ -487,7 +483,6 @@ export default defineComponent({ console.error(e) } }, - triggerActiveFileDownload() { if (this.isFileContentLoading) { return @@ -543,6 +538,36 @@ export default defineComponent({ imageRotateRight() { this.currentImageRotation = this.currentImageRotation === 270 ? 0 : this.currentImageRotation + 90 + }, + preloadImages() { + for (const activeFile of this.filteredFiles) { + if ( + activeFile.mimeType.toLowerCase().startsWith('audio') || + activeFile.mimeType.toLowerCase().startsWith('video') + ) { + continue + } + loadPreview({ + resource: this.activeFile, + isPublic: this.isPublicLinkContext, + server: configurationManager.serverUrl, + userId: this.user.id, + token: this.accessToken, + dimensions: [this.thumbDimensions, this.thumbDimensions] as [number, number] + }).then((mediaUrl) => { + this.cachedFiles.push({ + id: activeFile.id, + name: activeFile.name, + url: mediaUrl, + ext: activeFile.extension, + mimeType: activeFile.mimeType, + isImage: true, + isVideo: false, + isAudio: false + }) + console.log(this.cachedFiles) + }) + } } } }) From 84862c6f52474f14125784765904090a36244165 Mon Sep 17 00:00:00 2001 From: Jan Date: Thu, 1 Dec 2022 09:25:29 +0100 Subject: [PATCH 02/15] Enhancements --- packages/web-app-preview/src/App.vue | 31 +++++++++++++++++----------- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index 8f24eb483b5..358ce97b9ed 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -319,11 +319,11 @@ export default defineComponent({ }, isActiveFileTypeAudio() { - return this.activeFilteredFile.mimeType.toLowerCase().startsWith('audio') + return this.isFileTypeAudio(this.activeFilteredFile) }, isActiveFileTypeVideo() { - return this.activeFilteredFile.mimeType.toLowerCase().startsWith('video') + return this.isFileTypeVideo(this.activeFilteredFile) }, enterFullScreenDescription() { return this.$gettext('Enter full screen mode') @@ -539,16 +539,23 @@ export default defineComponent({ this.currentImageRotation = this.currentImageRotation === 270 ? 0 : this.currentImageRotation + 90 }, + isFileTypeImage(file) { + return !this.isFileTypeAudio(file) && !this.isFileTypeVideo(file) + }, + isFileTypeAudio(file) { + return file.mimeType.toLowerCase().startsWith('audio') + }, + + isFileTypeVideo(file) { + return file.mimeType.toLowerCase().startsWith('video') + }, preloadImages() { - for (const activeFile of this.filteredFiles) { - if ( - activeFile.mimeType.toLowerCase().startsWith('audio') || - activeFile.mimeType.toLowerCase().startsWith('video') - ) { + for (const file of this.filteredFiles) { + if (!this.isFileTypeImage(file)) { continue } loadPreview({ - resource: this.activeFile, + resource: file, isPublic: this.isPublicLinkContext, server: configurationManager.serverUrl, userId: this.user.id, @@ -556,11 +563,11 @@ export default defineComponent({ dimensions: [this.thumbDimensions, this.thumbDimensions] as [number, number] }).then((mediaUrl) => { this.cachedFiles.push({ - id: activeFile.id, - name: activeFile.name, + id: file.id, + name: file.name, url: mediaUrl, - ext: activeFile.extension, - mimeType: activeFile.mimeType, + ext: file.extension, + mimeType: file.mimeType, isImage: true, isVideo: false, isAudio: false From 898c2c48975811ad0ba4511b86c49921f5df3e51 Mon Sep 17 00:00:00 2001 From: Jan Date: Mon, 5 Dec 2022 10:22:59 +0100 Subject: [PATCH 03/15] Enhancements --- packages/web-app-preview/src/App.vue | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index 358ce97b9ed..1dd3d82a15d 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -210,6 +210,8 @@ export const mimeTypes = () => { ] } +const PRELOAD_IMAGE_COUNT = 10 + export default defineComponent({ name: 'Preview', components: { @@ -550,7 +552,22 @@ export default defineComponent({ return file.mimeType.toLowerCase().startsWith('video') }, preloadImages() { - for (const file of this.filteredFiles) { + let imageFilesToPreLoad = [] + const imageFiles = this.filteredFiles.filter((file) => this.isFileTypeImage(file)) + + // Load first 10 images in to cache + imageFilesToPreLoad.push(...imageFiles.slice(0, PRELOAD_IMAGE_COUNT)) + + // Load last 10 images in to cache + if (imageFiles.length > PRELOAD_IMAGE_COUNT) { + imageFilesToPreLoad.push( + ...imageFiles.slice( + -Math.min(imageFiles.length - PRELOAD_IMAGE_COUNT, PRELOAD_IMAGE_COUNT) + ) + ) + } + + for (const file of imageFilesToPreLoad) { if (!this.isFileTypeImage(file)) { continue } From d1df78de988d66e0a56f5586ac66b26f97f2a1a1 Mon Sep 17 00:00:00 2001 From: Jan Date: Mon, 5 Dec 2022 11:12:07 +0100 Subject: [PATCH 04/15] Enhancements --- packages/web-app-preview/src/App.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index 1dd3d82a15d..71ac3c3f7f0 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -191,6 +191,7 @@ import { loadPreview } from 'web-pkg/src/helpers' import { configurationManager } from 'web-pkg/src/configuration' import { createFileRouteOptions, mergeFileRouteOptions } from 'web-pkg/src/helpers/router' +const PRELOAD_IMAGE_COUNT = 5 export const appId = 'preview' export const mimeTypes = () => { @@ -268,7 +269,7 @@ export default defineComponent({ pageTitle() { const translated = this.$gettext('Preview for %{currentMediumName}') return this.$gettextInterpolate(translated, { - currentMediumName: this.activeFilteredFile?.name + currentMediumName: this.activeFilteredFile?.namedata }) }, ariaHiddenFileCount() { @@ -589,7 +590,6 @@ export default defineComponent({ isVideo: false, isAudio: false }) - console.log(this.cachedFiles) }) } } From 39d3f73ccec1e02a6c71d344bf60cc9ced6e94f8 Mon Sep 17 00:00:00 2001 From: Jan Date: Mon, 5 Dec 2022 11:31:52 +0100 Subject: [PATCH 05/15] Enhancements --- packages/web-app-preview/src/App.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index 71ac3c3f7f0..f335fdbe7d2 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -191,7 +191,7 @@ import { loadPreview } from 'web-pkg/src/helpers' import { configurationManager } from 'web-pkg/src/configuration' import { createFileRouteOptions, mergeFileRouteOptions } from 'web-pkg/src/helpers/router' -const PRELOAD_IMAGE_COUNT = 5 +const PRELOAD_IMAGE_COUNT = 10 export const appId = 'preview' export const mimeTypes = () => { From 814d4383598caa11fdb94c3d403a5ace3fba3998 Mon Sep 17 00:00:00 2001 From: Jan Date: Mon, 5 Dec 2022 11:51:37 +0100 Subject: [PATCH 06/15] Enhancements --- packages/web-app-preview/src/App.vue | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index f335fdbe7d2..a3d143643b4 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -556,6 +556,8 @@ export default defineComponent({ let imageFilesToPreLoad = [] const imageFiles = this.filteredFiles.filter((file) => this.isFileTypeImage(file)) + //TODO: Needs to pay attention to the current index + // Load first 10 images in to cache imageFilesToPreLoad.push(...imageFiles.slice(0, PRELOAD_IMAGE_COUNT)) From 659a1056157ba18d0b6348975d7534cf82805714 Mon Sep 17 00:00:00 2001 From: Jan Date: Fri, 9 Dec 2022 10:35:44 +0100 Subject: [PATCH 07/15] Fix preloading --- packages/web-app-preview/src/App.vue | 69 +++++++++++++++------------- 1 file changed, 37 insertions(+), 32 deletions(-) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index a3d143643b4..3477ac32048 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -367,6 +367,7 @@ export default defineComponent({ activeIndex(newValue, oldValue) { if (newValue !== oldValue) { this.loadMedium() + this.preloadImages() } if (oldValue !== null) { @@ -386,7 +387,6 @@ export default defineComponent({ await this.loadFolderForFileContext(this.currentFileContext) this.setActiveFile(this.currentFileContext.driveAliasAndItem) this.$refs.preview.focus() - this.preloadImages() }, beforeDestroy() { @@ -553,27 +553,10 @@ export default defineComponent({ return file.mimeType.toLowerCase().startsWith('video') }, preloadImages() { - let imageFilesToPreLoad = [] - const imageFiles = this.filteredFiles.filter((file) => this.isFileTypeImage(file)) + let toPreloadFiles = [] - //TODO: Needs to pay attention to the current index - - // Load first 10 images in to cache - imageFilesToPreLoad.push(...imageFiles.slice(0, PRELOAD_IMAGE_COUNT)) - - // Load last 10 images in to cache - if (imageFiles.length > PRELOAD_IMAGE_COUNT) { - imageFilesToPreLoad.push( - ...imageFiles.slice( - -Math.min(imageFiles.length - PRELOAD_IMAGE_COUNT, PRELOAD_IMAGE_COUNT) - ) - ) - } - - for (const file of imageFilesToPreLoad) { - if (!this.isFileTypeImage(file)) { - continue - } + const loadPreviewAsync = (file) => { + toPreloadFiles.push(file.id) loadPreview({ resource: file, isPublic: this.isPublicLinkContext, @@ -581,18 +564,40 @@ export default defineComponent({ userId: this.user.id, token: this.accessToken, dimensions: [this.thumbDimensions, this.thumbDimensions] as [number, number] - }).then((mediaUrl) => { - this.cachedFiles.push({ - id: file.id, - name: file.name, - url: mediaUrl, - ext: file.extension, - mimeType: file.mimeType, - isImage: true, - isVideo: false, - isAudio: false - }) }) + .then((mediaUrl) => { + this.cachedFiles.push({ + id: file.id, + name: file.name, + url: mediaUrl, + ext: file.extension, + mimeType: file.mimeType, + isImage: true, + isVideo: false, + isAudio: false + }) + }) + .catch((e) => { + console.error(e) + toPreloadFiles = toPreloadFiles.filter((fileId) => fileId !== file.id) + }) + } + + console.log('active index: ', this.activeIndex) + + for ( + let followingFileIndex = 1; + followingFileIndex <= PRELOAD_IMAGE_COUNT; + followingFileIndex++ + ) { + let cycleIndex = (this.activeIndex + followingFileIndex) % this.activeFiles.length + const file = this.filteredFiles[cycleIndex] + + if (!this.isFileTypeImage(file) || toPreloadFiles.includes(file.id)) { + continue + } + + loadPreviewAsync(file) } } } From dcbfe5f0ba136651e36c0be3e73ce57e51bd3d92 Mon Sep 17 00:00:00 2001 From: Jan Date: Mon, 12 Dec 2022 10:36:35 +0100 Subject: [PATCH 08/15] improve preloading --- packages/web-app-preview/src/App.vue | 30 ++++++++++++++++++++-------- 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index 3477ac32048..adeb91b052e 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -583,22 +583,36 @@ export default defineComponent({ }) } - console.log('active index: ', this.activeIndex) + const preloadUpcomingFile = (upcomingFileIndex) => { + let cycleIndex = + (((this.activeIndex + upcomingFileIndex) % this.filteredFiles.length) + + this.filteredFiles.length) % + this.filteredFiles.length - for ( - let followingFileIndex = 1; - followingFileIndex <= PRELOAD_IMAGE_COUNT; - followingFileIndex++ - ) { - let cycleIndex = (this.activeIndex + followingFileIndex) % this.activeFiles.length const file = this.filteredFiles[cycleIndex] if (!this.isFileTypeImage(file) || toPreloadFiles.includes(file.id)) { - continue + return } loadPreviewAsync(file) } + + for ( + let followingFileIndex = 1; + followingFileIndex <= PRELOAD_IMAGE_COUNT; + followingFileIndex++ + ) { + preloadUpcomingFile(followingFileIndex) + } + + for ( + let previousFileIndex = -1; + previousFileIndex >= PRELOAD_IMAGE_COUNT * -1; + previousFileIndex-- + ) { + preloadUpcomingFile(previousFileIndex) + } } } }) From 57dd497badda9912ca5497bab55df8b879d4942a Mon Sep 17 00:00:00 2001 From: Jan Date: Mon, 12 Dec 2022 10:47:31 +0100 Subject: [PATCH 09/15] improve preloading --- packages/web-app-preview/src/App.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index adeb91b052e..5ef7912c962 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -191,7 +191,6 @@ import { loadPreview } from 'web-pkg/src/helpers' import { configurationManager } from 'web-pkg/src/configuration' import { createFileRouteOptions, mergeFileRouteOptions } from 'web-pkg/src/helpers/router' -const PRELOAD_IMAGE_COUNT = 10 export const appId = 'preview' export const mimeTypes = () => { From df4f5278e743162eec79eccc252173c304dff973 Mon Sep 17 00:00:00 2001 From: Jan Date: Mon, 12 Dec 2022 10:48:36 +0100 Subject: [PATCH 10/15] improve preloading --- packages/web-app-preview/src/App.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index 5ef7912c962..3b631377997 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -268,7 +268,7 @@ export default defineComponent({ pageTitle() { const translated = this.$gettext('Preview for %{currentMediumName}') return this.$gettextInterpolate(translated, { - currentMediumName: this.activeFilteredFile?.namedata + currentMediumName: this.activeFilteredFile?.name }) }, ariaHiddenFileCount() { From 3ccb6b977d9ff7729607b103aa23fe04f536c879 Mon Sep 17 00:00:00 2001 From: Jan Date: Mon, 12 Dec 2022 10:52:24 +0100 Subject: [PATCH 11/15] Add changelog item --- changelog/unreleased/enhancement-preview-app-image-preloading | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 changelog/unreleased/enhancement-preview-app-image-preloading diff --git a/changelog/unreleased/enhancement-preview-app-image-preloading b/changelog/unreleased/enhancement-preview-app-image-preloading new file mode 100644 index 00000000000..d1439831b9b --- /dev/null +++ b/changelog/unreleased/enhancement-preview-app-image-preloading @@ -0,0 +1,4 @@ +Enhancement: Introduce image preloading to the preview app + +https://github.com/owncloud/web/pull/8051 +https://github.com/owncloud/web/issues/2052 From 8be11c4e987f3586b0dcdbbf706d258daf83e30c Mon Sep 17 00:00:00 2001 From: Jan Date: Mon, 12 Dec 2022 14:25:54 +0100 Subject: [PATCH 12/15] REN --- packages/web-app-preview/src/App.vue | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index 3b631377997..e6b14e75577 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -582,9 +582,9 @@ export default defineComponent({ }) } - const preloadUpcomingFile = (upcomingFileIndex) => { + const preloadFile = (preloadFileIndex) => { let cycleIndex = - (((this.activeIndex + upcomingFileIndex) % this.filteredFiles.length) + + (((this.activeIndex + preloadFileIndex) % this.filteredFiles.length) + this.filteredFiles.length) % this.filteredFiles.length @@ -602,7 +602,7 @@ export default defineComponent({ followingFileIndex <= PRELOAD_IMAGE_COUNT; followingFileIndex++ ) { - preloadUpcomingFile(followingFileIndex) + preloadFile(followingFileIndex) } for ( @@ -610,7 +610,7 @@ export default defineComponent({ previousFileIndex >= PRELOAD_IMAGE_COUNT * -1; previousFileIndex-- ) { - preloadUpcomingFile(previousFileIndex) + preloadFile(previousFileIndex) } } } From fd5884e29c5cb52f2cdb94f1f81602cf0c640fd8 Mon Sep 17 00:00:00 2001 From: Jan Date: Mon, 12 Dec 2022 14:43:29 +0100 Subject: [PATCH 13/15] Refactor --- packages/web-app-preview/src/App.vue | 62 ++++++++++++---------------- 1 file changed, 26 insertions(+), 36 deletions(-) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index e6b14e75577..5963dc3ffa7 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -457,26 +457,10 @@ export default defineComponent({ this.activeFilteredFile ) } else { - mediaUrl = await loadPreview({ - resource: this.activeFilteredFile, - isPublic: this.isPublicLinkContext, - server: configurationManager.serverUrl, - userId: this.user.id, - token: this.accessToken, - dimensions: [this.thumbDimensions, this.thumbDimensions] as [number, number] - }) + mediaUrl = await this.loadPreview(this.activeFilteredFile) } - this.cachedFiles.push({ - id: this.activeFilteredFile.id, - name: this.activeFilteredFile.name, - url: mediaUrl, - ext: this.activeFilteredFile.extension, - mimeType: this.activeFilteredFile.mimeType, - isVideo: this.isActiveFileTypeVideo, - isImage: this.isActiveFileTypeImage, - isAudio: this.isActiveFileTypeAudio - }) + this.addPreviewToCache(this.activeFilteredFile, mediaUrl) this.isFileContentLoading = false this.isFileContentError = false } catch (e) { @@ -551,30 +535,36 @@ export default defineComponent({ isFileTypeVideo(file) { return file.mimeType.toLowerCase().startsWith('video') }, + addPreviewToCache(file, url) { + this.cachedFiles.push({ + id: file.id, + name: file.name, + url, + ext: file.extension, + mimeType: file.mimeType, + isVideo: this.isFileTypeVideo(file), + isImage: this.isFileTypeImage(file), + isAudio: this.isFileTypeAudio(file) + }) + }, + loadPreview(file) { + return loadPreview({ + resource: file, + isPublic: this.isPublicLinkContext, + server: configurationManager.serverUrl, + userId: this.user.id, + token: this.accessToken, + dimensions: [this.thumbDimensions, this.thumbDimensions] as [number, number] + }) + }, preloadImages() { let toPreloadFiles = [] const loadPreviewAsync = (file) => { toPreloadFiles.push(file.id) - loadPreview({ - resource: file, - isPublic: this.isPublicLinkContext, - server: configurationManager.serverUrl, - userId: this.user.id, - token: this.accessToken, - dimensions: [this.thumbDimensions, this.thumbDimensions] as [number, number] - }) + this.loadPreview(file) .then((mediaUrl) => { - this.cachedFiles.push({ - id: file.id, - name: file.name, - url: mediaUrl, - ext: file.extension, - mimeType: file.mimeType, - isImage: true, - isVideo: false, - isAudio: false - }) + this.addPreviewToCache(file, mediaUrl) }) .catch((e) => { console.error(e) From 61b1d0f2512008e203ca40b6c24d959dc0985893 Mon Sep 17 00:00:00 2001 From: Jan Date: Tue, 13 Dec 2022 09:42:17 +0100 Subject: [PATCH 14/15] Fix preloading --- packages/web-app-preview/src/App.vue | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index 5963dc3ffa7..039d06eb24f 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -256,6 +256,7 @@ export default defineComponent({ direction: 'rtl', cachedFiles: [], + toPreloadImageIds: [], currentImageZoom: 1, currentImageRotation: 0 @@ -558,20 +559,21 @@ export default defineComponent({ }) }, preloadImages() { - let toPreloadFiles = [] - const loadPreviewAsync = (file) => { - toPreloadFiles.push(file.id) + this.toPreloadImageIds.push(file.id) this.loadPreview(file) + .then((mediaUrl) => { this.addPreviewToCache(file, mediaUrl) }) .catch((e) => { console.error(e) - toPreloadFiles = toPreloadFiles.filter((fileId) => fileId !== file.id) + this.toPreloadImageIds = this.toPreloadImageIds.filter((fileId) => fileId !== file.id) }) } + console.log('?????') + const preloadFile = (preloadFileIndex) => { let cycleIndex = (((this.activeIndex + preloadFileIndex) % this.filteredFiles.length) + @@ -580,7 +582,7 @@ export default defineComponent({ const file = this.filteredFiles[cycleIndex] - if (!this.isFileTypeImage(file) || toPreloadFiles.includes(file.id)) { + if (!this.isFileTypeImage(file) || this.toPreloadImageIds.includes(file.id)) { return } From 06db8be36c53c549113907c256ec00085e22df9c Mon Sep 17 00:00:00 2001 From: Jan Date: Tue, 13 Dec 2022 10:29:35 +0100 Subject: [PATCH 15/15] Update App.vue --- packages/web-app-preview/src/App.vue | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index 039d06eb24f..432a2fdcac8 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -572,8 +572,6 @@ export default defineComponent({ }) } - console.log('?????') - const preloadFile = (preloadFileIndex) => { let cycleIndex = (((this.activeIndex + preloadFileIndex) % this.filteredFiles.length) +