From 20e63df9904cb01b77033ac8332e815a3ae05305 Mon Sep 17 00:00:00 2001 From: Paul Neubauer Date: Mon, 5 Sep 2022 13:29:31 +0200 Subject: [PATCH 1/3] Enhancement: Remove clickOutside directive --- .../enhancement-remove-clickoutside-directive | 4 ++++ packages/web-runtime/src/defaults/vue.js | 3 --- packages/web-runtime/src/directives/clickOutside.js | 13 ------------- 3 files changed, 4 insertions(+), 16 deletions(-) create mode 100644 changelog/unreleased/enhancement-remove-clickoutside-directive diff --git a/changelog/unreleased/enhancement-remove-clickoutside-directive b/changelog/unreleased/enhancement-remove-clickoutside-directive new file mode 100644 index 00000000000..9cb6ccd49e7 --- /dev/null +++ b/changelog/unreleased/enhancement-remove-clickoutside-directive @@ -0,0 +1,4 @@ +Enhancement: Remove clickOutside directive + +We've removed the clickOutside directive because it isn't used anymore + diff --git a/packages/web-runtime/src/defaults/vue.js b/packages/web-runtime/src/defaults/vue.js index afe9ff9733d..a925c6daa58 100644 --- a/packages/web-runtime/src/defaults/vue.js +++ b/packages/web-runtime/src/defaults/vue.js @@ -5,7 +5,6 @@ import WebPlugin from '../plugins/web' import Avatar from '../components/Avatar.vue' import focusMixin from '../mixins/focusMixin' import lifecycleMixin from '../mixins/lifecycleMixin' -import ClickOutsideDirective from '../directives/clickOutside' import VueEvents from 'vue-events' import VueScrollTo from 'vue-scrollto' import VueResize from 'vue-resize' @@ -35,8 +34,6 @@ Vue.component('avatar-image', Avatar) Vue.mixin(focusMixin) Vue.mixin(lifecycleMixin) -Vue.directive('click-outside', ClickOutsideDirective) - // externalize Vue - this is not the Vue instance but the class window.Vue = Vue diff --git a/packages/web-runtime/src/directives/clickOutside.js b/packages/web-runtime/src/directives/clickOutside.js index 27a84923085..e69de29bb2d 100644 --- a/packages/web-runtime/src/directives/clickOutside.js +++ b/packages/web-runtime/src/directives/clickOutside.js @@ -1,13 +0,0 @@ -export default { - bind: function (el, binding, vnode) { - window.event = function (event) { - if (!(el === event.target || el.contains(event.target))) { - vnode.context[binding.expression](event) - } - } - document.body.addEventListener('click', window.event) - }, - unbind: function (el) { - document.body.removeEventListener('click', window.event) - } -} From f49c6b059f333e0ab03c40d0c80a510c0d7debaf Mon Sep 17 00:00:00 2001 From: Paul Neubauer Date: Mon, 5 Sep 2022 13:30:10 +0200 Subject: [PATCH 2/3] Update changelog --- changelog/unreleased/enhancement-remove-clickoutside-directive | 3 +++ 1 file changed, 3 insertions(+) diff --git a/changelog/unreleased/enhancement-remove-clickoutside-directive b/changelog/unreleased/enhancement-remove-clickoutside-directive index 9cb6ccd49e7..1d67c90e3dc 100644 --- a/changelog/unreleased/enhancement-remove-clickoutside-directive +++ b/changelog/unreleased/enhancement-remove-clickoutside-directive @@ -2,3 +2,6 @@ Enhancement: Remove clickOutside directive We've removed the clickOutside directive because it isn't used anymore +https://github.com/owncloud/web/pull/7584 +https://github.com/owncloud/web/issues/7572 + From 1e80111970eecce9768b7661d4a858f7d1195532 Mon Sep 17 00:00:00 2001 From: Paul Neubauer Date: Mon, 5 Sep 2022 13:31:59 +0200 Subject: [PATCH 3/3] remove clickOutside --- packages/web-runtime/src/directives/clickOutside.js | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 packages/web-runtime/src/directives/clickOutside.js diff --git a/packages/web-runtime/src/directives/clickOutside.js b/packages/web-runtime/src/directives/clickOutside.js deleted file mode 100644 index e69de29bb2d..00000000000