From 42c113aefced5db9514e8a0a54892625443fe639 Mon Sep 17 00:00:00 2001
From: Jannik Stehle <jannik.stehle@gmail.com>
Date: Thu, 12 May 2022 13:45:22 +0200
Subject: [PATCH] Remove private links from share notifications

---
 .../unreleased/bugfix-remove-links-from-share-notifications | 6 ++++++
 .../web-runtime/src/components/Topbar/Notifications.vue     | 5 ++++-
 2 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 changelog/unreleased/bugfix-remove-links-from-share-notifications

diff --git a/changelog/unreleased/bugfix-remove-links-from-share-notifications b/changelog/unreleased/bugfix-remove-links-from-share-notifications
new file mode 100644
index 00000000000..fe6ef1fe23e
--- /dev/null
+++ b/changelog/unreleased/bugfix-remove-links-from-share-notifications
@@ -0,0 +1,6 @@
+Bugfix: Remove private links from share notifications
+
+We've removed private links from share notifications because those were not working and also not needed.
+
+https://github.com/owncloud/web/pull/6955
+https://github.com/owncloud/web/issues/5227
diff --git a/packages/web-runtime/src/components/Topbar/Notifications.vue b/packages/web-runtime/src/components/Topbar/Notifications.vue
index 10d0e816f07..da87b8a51df 100644
--- a/packages/web-runtime/src/components/Topbar/Notifications.vue
+++ b/packages/web-runtime/src/components/Topbar/Notifications.vue
@@ -26,7 +26,7 @@
         <h4 v-text="el.subject" />
         <p v-if="el.message" class="oc-text-small">{{ el.message }}</p>
         <p>
-          <a v-if="el.link" :href="el.link" target="_blank">{{ el.link }}</a>
+          <a v-if="shouldDisplayLink(el)" :href="el.link" target="_blank">{{ el.link }}</a>
         </p>
         <div class="oc-width-1-1 oc-flex-right">
           <template v-if="el.actions.length !== 0">
@@ -106,6 +106,9 @@ export default {
           status: 'danger'
         })
       })
+    },
+    shouldDisplayLink(notification) {
+      return notification.link && notification.object_type !== 'local_share'
     }
   }
 }