From e2916b1fb9423b65c6f6bc12a3145f3c8e0446b6 Mon Sep 17 00:00:00 2001 From: JanAckermann Date: Thu, 5 May 2022 09:55:06 +0200 Subject: [PATCH 1/3] Decode uri --- packages/web-app-files/src/helpers/resources.ts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/web-app-files/src/helpers/resources.ts b/packages/web-app-files/src/helpers/resources.ts index 27f39db9d7b..01a593d553b 100644 --- a/packages/web-app-files/src/helpers/resources.ts +++ b/packages/web-app-files/src/helpers/resources.ts @@ -120,6 +120,14 @@ export function buildSpace(space) { if (space.special) { spaceImageData = space.special.find((el) => el.specialFolder.name === 'image') spaceReadmeData = space.special.find((el) => el.specialFolder.name === 'readme') + + if(spaceImageData){ + spaceImageData.webDavUrl = decodeURI(spaceImageData?.webDavUrl) + } + + if(spaceReadmeData) { + spaceReadmeData.webDavUrl = decodeURI(spaceReadmeData?.webDavUrl) + } } if (space.root?.permissions) { From 478d437ab07872c8d271cf969f1f452d48e87a87 Mon Sep 17 00:00:00 2001 From: JanAckermann Date: Thu, 5 May 2022 09:57:59 +0200 Subject: [PATCH 2/3] Add changelog item --- .../bugfix-space-image-not-shown-if-name-contains-blanks | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 changelog/unreleased/bugfix-space-image-not-shown-if-name-contains-blanks diff --git a/changelog/unreleased/bugfix-space-image-not-shown-if-name-contains-blanks b/changelog/unreleased/bugfix-space-image-not-shown-if-name-contains-blanks new file mode 100644 index 00000000000..a11bdae326e --- /dev/null +++ b/changelog/unreleased/bugfix-space-image-not-shown-if-name-contains-blanks @@ -0,0 +1,4 @@ +Bugfix: Space image not shown if file name contains blanks + +https://github.com/owncloud/web/pull/6881 +https://github.com/owncloud/web/issues/6874 From b01f38ab372b83df36ea61881dc721cdf87da242 Mon Sep 17 00:00:00 2001 From: JanAckermann Date: Thu, 5 May 2022 09:59:36 +0200 Subject: [PATCH 3/3] remove useless optional chaining --- packages/web-app-files/src/helpers/resources.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/web-app-files/src/helpers/resources.ts b/packages/web-app-files/src/helpers/resources.ts index 01a593d553b..d0535b3b748 100644 --- a/packages/web-app-files/src/helpers/resources.ts +++ b/packages/web-app-files/src/helpers/resources.ts @@ -121,12 +121,12 @@ export function buildSpace(space) { spaceImageData = space.special.find((el) => el.specialFolder.name === 'image') spaceReadmeData = space.special.find((el) => el.specialFolder.name === 'readme') - if(spaceImageData){ - spaceImageData.webDavUrl = decodeURI(spaceImageData?.webDavUrl) + if (spaceImageData) { + spaceImageData.webDavUrl = decodeURI(spaceImageData.webDavUrl) } - if(spaceReadmeData) { - spaceReadmeData.webDavUrl = decodeURI(spaceReadmeData?.webDavUrl) + if (spaceReadmeData) { + spaceReadmeData.webDavUrl = decodeURI(spaceReadmeData.webDavUrl) } }