Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish the upload overlay #6837

Merged
merged 3 commits into from
May 2, 2022
Merged

Polish the upload overlay #6837

merged 3 commits into from
May 2, 2022

Conversation

JammingBen
Copy link
Contributor

Description

  • Polished the design of the overlay a bit
  • Header now shows the amount of successful uploads

Followup for #6202

Related Issue

Screenshots:

image

@JammingBen JammingBen self-assigned this Apr 29, 2022
@JammingBen JammingBen mentioned this pull request Apr 29, 2022
Closed
10 tasks
@JammingBen
Copy link
Contributor Author

I'm not super happy about the handling of failed uploads for several reasons:

  • Uploading 3 files where 1 upload fails -> it says "0 of 1 file uploaded", although it should be "2 of 3 files uploaded" or even better "1 of 3 files failed to upload"
  • It would be nice to know which files failed to upload
  • Design is "okay-ish"

Unfortunately, this part comes from the Uppy StatusBar plugin, so we can't easily change that. For the future we might kick that plugin and implement our own solution. But for now we're fine IMO.

@JammingBen JammingBen force-pushed the polish-upload-overlay branch from 103e3f8 to 073925b Compare April 29, 2022 08:27
@JammingBen JammingBen marked this pull request as ready for review April 29, 2022 08:27
@JammingBen JammingBen requested review from kulmann and dschmidt April 29, 2022 08:27
@owncloud owncloud deleted a comment from update-docs bot Apr 29, 2022
kulmann
kulmann approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool 👍

packages/web-runtime/src/components/UploadInfo.vue Outdated Show resolved Hide resolved
@ownclouders
Copy link
Contributor

ownclouders commented Apr 29, 2022 •
edited
Loading

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/25042/68/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen force-pushed the polish-upload-overlay branch from 36313ac to 50c6092 Compare May 2, 2022 06:55
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 82cdbab into master May 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the polish-upload-overlay branch May 2, 2022 07:34
@micbar micbar mentioned this pull request May 5, 2022
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @ownclouders @kulmann