Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web+ocis] Make default link permission configurable #9919

Closed
12 tasks
tbsbdr opened this issue Nov 8, 2023 · 5 comments · Fixed by #10038
Closed
12 tasks

[web+ocis] Make default link permission configurable #9919

tbsbdr opened this issue Nov 8, 2023 · 5 comments · Fixed by #10038
Assignees
Labels
Priority:p3-medium Normal priority Type:Story User Story

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Nov 8, 2023

Description

User Stories

  • As an Admin I want to set the default link permission so that it fits to the policy of my organisation.

  • As an Admin I want that ownCloud provides privacy by default so that I don't need to take care of privacy focused settings.

Value

  • provide privacy by default

Acceptance Criteria

  • provide an ocis config option + capability for the default link permission
  • Options correlate to:
    • Only for invited people
    • Anyone with the link can view
    • (tbd: should we provide the other roles as well? I can hardly imagine usecases where Anyone with the link can edit should be the default)
    • Default correlates to anyone with the link can view, i.e. permission 1
  • Investigate: does a default link permission of 0 conflict with a default password policy? permission 0 links must always be created without password.

Definition of ready

  • Everybody needs to understand the value written in the user story
  • Acceptance criteria have to be defined
  • All dependencies of the user story need to be identified
  • Feature should be seen from an end user perspective
  • Story has to be estimated
  • Story points need to be less than 20

Definition of done

  • Functional requirements
    • Functionality described in the user story works
    • Acceptance criteria are fulfilled
  • Quality
    • Code review happened
    • CI is green (that includes new and existing automated tests)
    • Critical code received unit tests by the developer
  • Non-functional requirements
    • No sonar cloud issues
@tbsbdr
Copy link
Contributor Author

tbsbdr commented Nov 8, 2023

CC @michaelstingl

@kulmann
Copy link
Member

kulmann commented Nov 8, 2023

I'm kind of confused by this story... the password story ( owncloud/ocis#7682 ) is a good idea, but locking everything down in the first place seems to me like it will prevent successful/easy collaboration.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Nov 8, 2023

@hodyroff what is your take on that?

@hodyroff
Copy link

hodyroff commented Nov 8, 2023

I think as an admin I like to decide if the the default for my users shall be "invited people" or "link". Later the decision should be delegateable to Spaces and/or to Users (advanced settings). Default should be "invited users".
If its sysadmin as a first step, thats ok.

@tbsbdr tbsbdr changed the title Set Default Link Permission to "Only for invited people" Make default link permission configurable Nov 11, 2023
@tbsbdr
Copy link
Contributor Author

tbsbdr commented Nov 11, 2023

Update: revised the initial comment; applied agile story-format;

@tbsbdr tbsbdr moved this from Qualification to Backlog in Infinite Scale Team Board Nov 11, 2023
@tbsbdr tbsbdr added Priority:p3-medium Normal priority Type:Story User Story labels Nov 11, 2023
@kulmann kulmann changed the title Make default link permission configurable [web+ocis] Make default link permission configurable Nov 21, 2023
@JammingBen JammingBen self-assigned this Nov 22, 2023
@JammingBen JammingBen moved this from Backlog to In progress in Infinite Scale Team Board Nov 22, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Story User Story
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants