Share Jail private link doesn't resolve nicely in web

[michaelstingl]

Describe the bug

Private link generated in desktop client with "Show in web browser" doesn't work in web.

Steps to reproduce

Steps to reproduce the behavior:

1. setup desktop client with einstein:[email protected]
2. get private link with "Show in web browser"

➡️ https://ocis.ocis-traefik.latest.owncloud.works/f/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668%21a0ca6a90-a365-4782-871e-d44447bbc668 💥

Expected behavior

I'd like to see the "Shared with me" page.

Actual behavior

I see a misleading error page

Setup

Please describe how you started the server and provide a list of relevant environment variables or configuration files.

[Log]  ownCloud Web UI 8.0.0-alpha.4  (index.html-3c2aed60.mjs, line 1)
[Log]  Infinite Scale 4.0.0+337dca17e Community  (index.html-3c2aed60.mjs, line 1)

Additional context

23-10-25 18:06:44:696 [ info sync.httplogger ]:	"ed83de82-d7d8-4380-8eae-3e4568df4bd8: 
Request: GET https://ocis.ocis-traefik.latest.owncloud.works/graph/v1.0/me/drives 
Header: { Authorization: Bearer [redacted], User-Agent: Mozilla/5.0 (Macintosh) mirall/6.0.0.12479-daily20231025 (testpilotcloud, macos-23.0.0 ClientArchitecture: arm64 OsArchitecture: arm64), Accept: */*, Accept-Language: en_DE, X-Request-ID: ed83de82-d7d8-4380-8eae-3e4568df4bd8, Original-Request-ID: ed83de82-d7d8-4380-8eae-3e4568df4bd8, } 
Data: []"

23-10-25 18:06:44:754 [ info sync.httplogger ]:	"ed83de82-d7d8-4380-8eae-3e4568df4bd8: 
Response: GET 200 (57ms) https://ocis.ocis-traefik.latest.owncloud.works/graph/v1.0/me/drives 
Header: { Content-Length: 1344, Content-Security-Policy: frame-ancestors 'none', Content-Type: application/json, Date: Wed, 25 Oct 2023 16:06:44 GMT, Vary: Origin, X-Content-Type-Options: nosniff, X-Frame-Options: DENY, X-Graph-Version: 4.0.0+337dca17e, X-Request-Id: ed83de82-d7d8-4380-8eae-3e4568df4bd8, } 
Data: [{
    "value":
    [
        {
            "driveAlias": "personal/einstein",
            "driveType": "personal",
            "id": "733608e6-f9f8-4b43-b884-aa3d5d28929f$4c510ada-c86b-4815-8820-42cdf82c3d51",
            "lastModifiedDateTime": "2023-10-25T08:49:33.921967152Z",
            "name": "Albert Einstein",
            "owner":
            {
                "user":
                {
                    "displayName": "",
                    "id": "4c510ada-c86b-4815-8820-42cdf82c3d51"
                }
            },
            "quota":
            {
                "remaining": 34933362688,
                "state": "normal",
                "total": 0,
                "used": 0
            },
            "root":
            {
                "eTag": "\"629120d85b67008d4f3bcafa0c06e7d2\"",
                "id": "733608e6-f9f8-4b43-b884-aa3d5d28929f$4c510ada-c86b-4815-8820-42cdf82c3d51",
                "webDavUrl": "https://ocis.ocis-traefik.latest.owncloud.works/dav/spaces/733608e6-f9f8-4b43-b884-aa3d5d28929f$4c510ada-c86b-4815-8820-42cdf82c3d51"
            },
            "webUrl": "https://ocis.ocis-traefik.latest.owncloud.works/f/733608e6-f9f8-4b43-b884-aa3d5d28929f$4c510ada-c86b-4815-8820-42cdf82c3d51"
        },
        {
            "driveAlias": "virtual/shares",
            "driveType": "virtual",
            "id": "a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668",
            "name": "Shares",
            "root":
            {
                "eTag": "DECAFC00FEE",
                "id": "a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668",
                "webDavUrl": "https://ocis.ocis-traefik.latest.owncloud.works/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668"
            },
            "webUrl": "https://ocis.ocis-traefik.latest.owncloud.works/f/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668"
        }
    ]
}\n]"

23-10-25 18:04:40:210 [ info sync.httplogger ]:	"aac7efab-d1a4-41c6-82ad-cb3854c6abe2: 
Request: PROPFIND https://ocis.ocis-traefik.latest.owncloud.works/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668/ 
Header: { Depth: 0, Prefer: return=minimal, Authorization: Bearer [redacted], User-Agent: Mozilla/5.0 (Macintosh) mirall/6.0.0.12479-daily20231025 (testpilotcloud, macos-23.0.0 ClientArchitecture: arm64 OsArchitecture: arm64), Accept: */*, Accept-Language: en_DE, Content-Type: text/xml; charset=utf-8, X-Request-ID: aac7efab-d1a4-41c6-82ad-cb3854c6abe2, Original-Request-ID: aac7efab-d1a4-41c6-82ad-cb3854c6abe2, Content-Length: 141, } 
[<?xml version="1.0" encoding="utf-8"?>
<d:propfind xmlns:d="DAV:">
	<d:prop>
		<privatelink xmlns="http://owncloud.org/ns"/>
	</d:prop>
</d:propfind>\n]"

23-10-25 18:04:40:268 [ info sync.httplogger ]:	"aac7efab-d1a4-41c6-82ad-cb3854c6abe2: 
Response: PROPFIND 207 (58ms) https://ocis.ocis-traefik.latest.owncloud.works/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668/ 
Header: { Access-Control-Allow-Origin: *, Access-Control-Expose-Headers: Tus-Resumable, Tus-Version, Tus-Extension, Content-Length: 514, Content-Security-Policy: default-src 'none';, Content-Type: application/xml; charset=utf-8, Date: Wed, 25 Oct 2023 16:04:40 GMT, Dav: 1, 3, extended-mkcol, Preference-Applied: return=minimal, Tus-Extension: creation,creation-with-upload,checksum,expiration, Tus-Resumable: 1.0.0, Tus-Version: 1.0.0, Vary: Prefer, X-Content-Type-Options: nosniff, X-Download-Options: noopen, X-Frame-Options: SAMEORIGIN, X-Permitted-Cross-Domain-Policies: none, X-Request-Id: aac7efab-d1a4-41c6-82ad-cb3854c6abe2, X-Robots-Tag: none, X-Xss-Protection: 1; mode=block, } 
[<d:multistatus xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:s="http://sabredav.org/ns">
	<d:response>
		<d:href>/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668/</d:href>
		<d:propstat>
			<d:prop>
				<oc:privatelink>https://ocis.ocis-traefik.latest.owncloud.works/f/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668%21a0ca6a90-a365-4782-871e-d44447bbc668</oc:privatelink>
			</d:prop>
			<d:status>HTTP/1.1 200 OK</d:status>
		</d:propstat>
	</d:response>
</d:multistatus>]"

[kulmann]

You found an edge case: the share jail itself is not available via webdav in web. The web ui loads all shares via OCS API (in the future: via graph API). But since the share jail id is hardcoded in web, we can add special handling to the private link resolve page. Correct behaviour would be: if the private link points to the share jail, redirect to the shared with me page itself.

I'll move this issue to the web repo.

[kulmann]

To whoever picks this issue: please also check if web resolves the private link for a space root correctly (personal space, any project space).

[kulmann]

Elevated the priority to p2. We want this fixed in the stable-7.1 branch and release it for ocis stable-4.0.