Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No redirect to shares with me page while opening internal link in case auto_accept_share #9776

Closed
ScharfViktor opened this issue Oct 6, 2023 · 0 comments · Fixed by #9821
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Oct 6, 2023

Precondition:

  • run ocis using FRONTEND_AUTO_ACCEPT_SHARES: "true"
  • user katherine disables auto sharing: curl --insecure -X POST -u katherine:gemini https://localhost:9200/api/v0/settings/values-save -d '{"value":{"accountUuid":"me","bundleId":"2a506de7-99bd-4f0d-994e-c38e72c28fd9","settingId":"ec3ed4a3-3946-4efc-8f9f-76d38b12d3a9","resource":{"type":"TYPE_USER"},"boolValue":false}}'

Steps:

  • admin creates folder and shares to katherine and richard
  • admin creates internal link to folder
  • users open link

Expected: redirect to shares->shares with me
Actual: if users have FRONTEND_AUTO_ACCEPT_SHARES: "true" (in the feature -> default) redirect doesn't work

Screen.Recording.2023-10-06.at.15.38.59.mov

NOTE: please enablecode after fixing:
https://github.com/owncloud/web/pull/9775/files#diff-51d1aa97f08184d1170eefe0765f26efa2b7f0f92bfa8079115e30eaf959218eR105-R112

and https://github.com/owncloud/web/pull/9775/files#diff-613727c41c6d01f3377cea44044287cc7f6948c87f3e2a2c4160405fbf14066eR22

@ScharfViktor ScharfViktor added the Type:Bug Something isn't working label Oct 6, 2023
@JammingBen JammingBen added the Priority:p3-medium Normal priority label Oct 9, 2023
@JammingBen JammingBen moved this to Bugs Prio 3 or less in Web Support Board Oct 9, 2023
@JammingBen JammingBen self-assigned this Oct 17, 2023
@JammingBen JammingBen moved this from Bugs Prio 3 or less to In progress in Web Support Board Oct 17, 2023
@kulmann kulmann moved this from Qualification to In progress in Infinite Scale Team Board Oct 27, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
Archived in project
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants