Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloud import] Dark theme does not apply to uppy dashboard #9452

Closed
JammingBen opened this issue Jul 20, 2023 · 2 comments · Fixed by #9884
Closed

[cloud import] Dark theme does not apply to uppy dashboard #9452

JammingBen opened this issue Jul 20, 2023 · 2 comments · Fixed by #9884
Labels
Priority:p4-low Low priority Type:Bug Something isn't working

Comments

@JammingBen
Copy link
Contributor

The dark theme does not apply to the uppy dashboard which is used for the cloud import. We should use our color tokens here.

image
@JammingBen JammingBen added Type:Bug Something isn't working Priority:p4-low Low priority labels Jul 20, 2023
@github-project-automation github-project-automation bot moved this from Bugs Prio 3 or less to Qualification in Web Support Board Jul 20, 2023
@JammingBen JammingBen moved this to Bugs Prio 3 or less in Web Support Board Jul 20, 2023
@JammingBen JammingBen changed the title [Cloud import] Dark theme does not apply to uppy dashboard [cloud import] Dark theme does not apply to uppy dashboard Jul 20, 2023
@dschmidt
Copy link
Member

Especially the WebDav Formulars look pretty bad, we need to check whether we need to handle that in our upstream PR as well - somehow...

@dschmidt
Copy link
Member

... oh and uppy has a dark mode as well, maybe we can just use that. We would need to tie it to our own dark mode switch then

@JammingBen JammingBen moved this from Qualification to Bugs Prio 3 or less in Web Support Board Jul 28, 2023
@kulmann kulmann moved this to Prio 3 or less in Infinite Scale Team Board Oct 27, 2023
@AlexAndBear AlexAndBear mentioned this issue Oct 30, 2023
Merged
10 tasks
@github-project-automation github-project-automation bot moved this from Prio 3 or less to Done in Infinite Scale Team Board Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority:p4-low Low priority Type:Bug Something isn't working
Projects
Infinite Scale Team Board
Archived in project
Web Support Board
Status: Bugs Prio 3 or less
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enable dark theme on uppy importer owncloud/web
2 participants
@dschmidt @JammingBen