Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically open single file share app #9380

Closed
tbsbdr opened this issue Jul 10, 2023 · 11 comments
Closed

Automatically open single file share app #9380

tbsbdr opened this issue Jul 10, 2023 · 11 comments

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 10, 2023

relates to b29df64

When opening the single file view, it automatically opens the default app.
It was discussed that this would not come upstream, but apparently it's already there...

Acceptance Criteria:

  • auto-open should be enabled/disabled via config file
@tbsbdr tbsbdr added this to the CERN Web Merge milestone Jul 10, 2023
@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jul 10, 2023

question to @diocas @elizavetaRa

  • auto-open should be enabled/disabled via config file, right?

@elizavetaRa
Copy link
Member

I'd say yes

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jul 11, 2023

Daily

  • Default for CERN would also be auto-open

@pascalwengerter
Copy link
Contributor

Daily

* Default for CERN would also be auto-open

So is there a to-do left here? I noticed some ambiguity in the commit message the other day and wasn't sure whether CERN's needs are met already or not

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jul 13, 2023

yes, added AC to initial post

auto-open should be enabled/disabled via config file

Although auto open already fulfills CERNs use case, I would like to be able to have this configurable for the product. this could also be a good candidate for regular sprint story; do you agree @JammingBen?

@JammingBen
Copy link
Contributor

Configuration is always nice on paper, but I feel like we shouldn't overdo it with configurable UI behaviour. Especially since we already have the single-file-view itself configurable. So if auto-open is default for the product as well as for Cern, I'd prefer not having this configurable. Ultimately you decide though 🙂

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jul 13, 2023

@elizavetaRa is making the auto-open behaviour configurable a mandatory for the CERN Web Merge Project?
If not I'd be fine having it not configurable until we receive crucial feedback / i.e. focus now on getting more important things done.

@elizavetaRa
Copy link
Member

For us not mandatory, answered yes initially as I thought you want to disable auto-open on default

@pascalwengerter
Copy link
Contributor

@tbsbdr shall we remove it from the CERN bucket list (or "check the box with a note"), then? The issue can be left open I suppose for future reference/implementation down the road

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jul 14, 2023

clarified & checked ✅ linked the PR that solved the intend in the bucket list

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jul 17, 2023

Feature is configurable already via WEB_OPTION_OPEN_LINKS_WITH_DEFAULT_APP

@tbsbdr tbsbdr closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants