Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O365: Open Non "Personal" Documents in View Mode per Default #9255

Closed
tbsbdr opened this issue Jun 16, 2023 · 3 comments · Fixed by #9879
Closed

O365: Open Non "Personal" Documents in View Mode per Default #9255

tbsbdr opened this issue Jun 16, 2023 · 3 comments · Fixed by #9879

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 16, 2023

Description

User Stories

  • As a user who clicks on a presentation, document or spreadsheet outside my Personal folder, I want that the file gets opened in view-only-mode in O365 so that I don't apply changes accidentally.

Value

  • error prevention
  • improve collaboration

Acceptance Criteria

  • applies only to documents that are stored outside the users Home Folder (= "Personal"), eg. Shares & Spaces
  • click on presentation, document or spreadsheet opens O365 in view mode per default
  • if the user wants to edit the file, he/she needs an extra click on "Edit" to switch to editing Mode

In view mode, switch to edit mode:
screenshot_001232

In edit mode, switch to other modes:
246333658-7cfec590-de88-4904-a71b-1299e819d59c

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] code review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues

relates to 2894f0c

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Oct 30, 2023

@kulmann makes sense for the product I'd say, do you agree?

@kulmann
Copy link
Member

kulmann commented Oct 30, 2023

@kulmann makes sense for the product I'd say, do you agree?

For Shares, including public links, I agree. But for Spaces I'm not fully convinced. At least it's more complex than that. I believe the wish for exceptions like "immediate edit mode if I'm the file owner" or "immediate edit mode if I'm the space manager" would arise quickly...

@JammingBen
Copy link
Contributor

Implemented via #9879. The new config option editor.openAsPreview needs to be set to enable this feature. It can either be true to enable it for all apps, or an array of apps, e.g. ['Office356'].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants