Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create EOS Projects on request #9228

Closed
tbsbdr opened this issue Jun 14, 2023 · 7 comments
Closed

Create EOS Projects on request #9228

tbsbdr opened this issue Jun 14, 2023 · 7 comments

Comments

@tbsbdr
Copy link

tbsbdr commented Jun 14, 2023

Description

relates to 6b774f2

User Stories

  • As CERN I want that Projects can only be created asynchronously upon request so that we can keep track of projects.

Value

Acceptance Criteria

  • hide the space creation form for all users at all times (could already be fulfilled, because reva master doesn't provide permissions...)
  • provide an option to put a custom button on the spaces overview:
    • needs custom label (technical detail for implementation: require translations for the label in config already, or do we use the additional translations feature?)
    • links to an external page (project creation request form)
    • button is available for all regular users (Button is not available for lightweight accounts)
  • add documentation for how to provide custom translations (if we go that way for the button label translation)

Note: User gets notified about approved (created) Project via E-Mail Ticket

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] code review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues
@kulmann
Copy link
Contributor

kulmann commented Jun 20, 2023

@diocas @elizavetaRa is the project creation available for lightweight accounts?

@kulmann
Copy link
Contributor

kulmann commented Jun 20, 2023

@dschmidt possible requirement for the extension system: custom button in the spaces overview

@dschmidt
Copy link
Member

@dschmidt possible requirement for the extension system: custom button in the spaces overview

That's easy, more interesting is how to hide the default button 🤔

@kulmann
Copy link
Contributor

kulmann commented Jun 20, 2023

@dschmidt possible requirement for the extension system: custom button in the spaces overview

That's easy, more interesting is how to hide the default button 🤔

It's automatically hidden if the user doesn't have the permission to create spaces. So we should probably make the default user permissions configurable. Or maybe it's already done, because CERN doesn't provide the endpoint for listing permissions...

@diocas
Copy link
Contributor

diocas commented Jun 20, 2023

@diocas @elizavetaRa is the project creation available for lightweight accounts?

No

@JammingBen
Copy link
Contributor

We currently don't see a good extension entry point here. #9816 adds a custom component for CERN where the custom URL, label and potential permission checks can be handled.

This checks all the acceptance criteria of this issue, is that correct? @diocas

@tbsbdr
Copy link
Author

tbsbdr commented Oct 19, 2023

we'll go with the hardcoded solution for now #9816
any other more generic solution would be useful for the product but must happen in the future;

@tbsbdr tbsbdr closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants